Skip to content

Conversation

@cmdoug
Copy link
Contributor

@cmdoug cmdoug commented Sep 19, 2025

No description provided.

@cmdoug cmdoug marked this pull request as draft September 20, 2025 00:55
@cmdoug
Copy link
Contributor Author

cmdoug commented Sep 20, 2025

I am trying to understand things well enough to fix #319, but I am pretty perplexed and making little progress. These are just some mundane things I noticed while poking around.

@cmdoug cmdoug marked this pull request as ready for review September 20, 2025 03:36
@cmdoug cmdoug marked this pull request as draft September 20, 2025 10:49
@cmdoug
Copy link
Contributor Author

cmdoug commented Sep 20, 2025

I'm going to keep this marked as a draft to have a catchall branch for minor changes as I poke around further

@cmdoug
Copy link
Contributor Author

cmdoug commented Sep 30, 2025

Hi @prj-, do you have thoughts on whether we merge these minor changes to purge all of this "dead logic"? Or is it really being held there for some reason? For example, see my review comment above -- it looks like maybe some of the logic was meant as a switch for testing, and it is unclear whether it is supposed to be active or unactive in the actual code.
Also, on a side note, is there any plan to bring in some form of enforced format (e.g. Clang format) for the FF codebase? Something like this would be a helpful add I think.

@prj-
Copy link
Member

prj- commented Sep 30, 2025

I'm going to keep this marked as a draft

Is it still a draft or is it now ready for review?

@cmdoug cmdoug marked this pull request as ready for review September 30, 2025 13:37
@cmdoug
Copy link
Contributor Author

cmdoug commented Sep 30, 2025

Can be reviewed. Its pretty minor stuff mostly, but some of the changes make me wonder about the original intent.

@prj- prj- self-requested a review September 30, 2025 18:44
@prj-
Copy link
Member

prj- commented Sep 30, 2025

About the use of clang-format, it should be used. Unfortunately, I'm not sure what happened last time, but it messed up some of the repo, see f715746.

@prj- prj- merged commit ad41cb8 into FreeFem:develop Sep 30, 2025
38 checks passed
@cmdoug cmdoug deleted the minor_fixes branch September 30, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants