-
Notifications
You must be signed in to change notification settings - Fork 203
Minor fixes #364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor fixes #364
Conversation
|
I am trying to understand things well enough to fix #319, but I am pretty perplexed and making little progress. These are just some mundane things I noticed while poking around. |
|
I'm going to keep this marked as a draft to have a catchall branch for minor changes as I poke around further |
|
Hi @prj-, do you have thoughts on whether we merge these minor changes to purge all of this "dead logic"? Or is it really being held there for some reason? For example, see my review comment above -- it looks like maybe some of the logic was meant as a switch for testing, and it is unclear whether it is supposed to be active or unactive in the actual code. |
Is it still a draft or is it now ready for review? |
|
Can be reviewed. Its pretty minor stuff mostly, but some of the changes make me wonder about the original intent. |
|
About the use of clang-format, it should be used. Unfortunately, I'm not sure what happened last time, but it messed up some of the repo, see f715746. |
No description provided.