Skip to content

Conversation

@jguegel
Copy link
Contributor

@jguegel jguegel commented Dec 16, 2025

Type of change(s)

  • Bug fix
  • Feature / enhancement
  • Infrastructure / tooling (CI, build, deps, tests)
  • Documentation

What changed and why

  • Added intent for multiple file "save as"-share menu
  • Added @Suppress("TooManyFunctions") to avoid detekt error with too many functions in SaveAsActivity
  • No UI change
  • Using same behavior like sanitizeFilename & findAvailableName
  • Added new strings (files_saved, files_saved_partially)

Closes the following issue(s)

Checklist

  • I read the contribution guidelines.
  • I manually tested my changes on device/emulator (if applicable).
  • I updated the "Unreleased" section in CHANGELOG.md (if applicable).
  • I have self-reviewed my pull request (no typos, formatting errors, etc.).
  • All checks are passing.

@jguegel jguegel requested a review from naveensingh as a code owner December 16, 2025 18:28
Copy link
Member

@naveensingh naveensingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a quick review.

FYI: Conventional commits (and PR title) are preferred. This is mentioned in https://github.com/FossifyOrg/General-Discussion#contributing-code (point 3). "added:" is not a valid type.

@naveensingh naveensingh changed the title added: "save as"-intent for multiple files #345 feat: handle saving multiple files Dec 21, 2025
@jguegel
Copy link
Contributor Author

jguegel commented Dec 22, 2025

thanks for the feedback, didn't know about the plural strings
fyi i will be out till february

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Save as" in the share menu not available when multiple files are selected

2 participants