Skip to content

fix: adapt tests for netbox 4.2+ #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: adapt tests for netbox 4.2+ #222

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba360d2
fix: adapt tests for netbox 4.2+
koalajoe23 Jul 24, 2025
d2c8b91
fix: backwards compatibility for tests
koalajoe23 Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions netbox_prometheus_sd/tests/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,10 @@ def build_vm_full(name, ip_octet=1):
vm.tags.add("Tag 2")
vm.save()

Service.objects.create(virtual_machine=vm, name="ssh", protocol="tcp", ports=[22])
try: # NetBox 4.2+
Service.objects.create(parent=vm, name="ssh", protocol="tcp", ports=[22])
except AttributeError: # NetBox <4.2
Service.objects.create(virtual_machine=vm, name="ssh", protocol="tcp", ports=[22])
return vm


Expand Down Expand Up @@ -229,7 +232,10 @@ def build_device_full(name, ip_octet=1):
device.tags.add("Tag 2")
device.save()
device.position = 1.0
Service.objects.create(device=device, name="ssh", protocol="tcp", ports=[22])
try: # NetBox 4.2+
Service.objects.create(parent=device, name="ssh", protocol="tcp", ports=[22])
except AttributeError: # NetBox <4.2
Service.objects.create(device=device, name="ssh", protocol="tcp", ports=[22])
return device


Expand Down