Skip to content

Make NamedType iteration predictable by using LinkedHashSet instead of HashSet in StdSubtypeResolver.collectAndResolveSubtypesByTypeId() #4086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2023
Merged

Make NamedType iteration predictable by using LinkedHashSet instead of HashSet in StdSubtypeResolver.collectAndResolveSubtypesByTypeId() #4086

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/com/fasterxml/jackson/databind/jsontype/impl/StdSubtypeResolver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ public Collection<NamedType> collectAndResolveSubtypesByTypeId(MapperConfig<?> c
Class<?> rawBase = baseType.getRawClass();

// Need to keep track of classes that have been handled already
Set<Class<?>> typesHandled = new HashSet<Class<?>>();
Set<Class<?>> typesHandled = new LinkedHashSet<Class<?>>();
Map<String,NamedType> byName = new LinkedHashMap<String,NamedType>();

// start with lowest-precedence, which is from type hierarchy
Expand Down Expand Up @@ -205,7 +205,7 @@ public Collection<NamedType> collectAndResolveSubtypesByTypeId(MapperConfig<?> c
AnnotatedClass baseType)
{
final Class<?> rawBase = baseType.getRawType();
Set<Class<?>> typesHandled = new HashSet<Class<?>>();
Set<Class<?>> typesHandled = new LinkedHashSet<Class<?>>();
Map<String,NamedType> byName = new LinkedHashMap<String,NamedType>();

NamedType rootType = new NamedType(rawBase, null);
Expand Down