Skip to content

Conversation

@nrayburn-tech
Copy link
Contributor

No description provided.

public B configureForJackson2() {
return disable(StreamReadFeature.USE_FAST_DOUBLE_PARSER)
.disable(StreamReadFeature.USE_FAST_BIG_NUMBER_PARSER);
return enable(StreamReadFeature.INCLUDE_SOURCE_IN_LOCATION)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, in Jackson 2.20 it is already disabled:

          *
          * @since 2.9 (but different default since 2.16)
          */
         INCLUDE_SOURCE_IN_LOCATION(false),

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this javadoc is wrong in 2.x,

* Feature is enabled by default, meaning that "source reference" information is passed
.

Removed this change.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. I'll fix Javadoc then.

@nrayburn-tech nrayburn-tech force-pushed the additional-jackson2-config branch from 4f3c662 to 3346679 Compare December 2, 2025 03:55
@cowtowncoder cowtowncoder added the cla-needed PR looks good (although may also require code review), but CLA needed from submitter label Dec 2, 2025
@cowtowncoder
Copy link
Member

Ok, one process thing: we'll need CLA (just once) before I can merge this (I did merge the other one first before remembering to ask for one). Just needs to be sent once, good for all future contributions:

https://github.com/FasterXML/jackson/blob/main/contributor-agreement.pdf

the usual way is to print, fill & sign, scan/photo, email to cla at fasterxml dot com.

Once we got it, will merge.

Thank you again!

@nrayburn-tech
Copy link
Contributor Author

I sent it a bit ago before the first PR was created, so you should have it. If not, let me know and I can resend it.

@nrayburn-tech
Copy link
Contributor Author

Looks like the contributing doc has a different email address, email that copy to info at fasterxml dot com.. https://github.com/FasterXML/jackson/blob/main/CONTRIBUTING.md

Just resent it to the cla address.

@cowtowncoder
Copy link
Member

@nrayburn-tech Sorry, got them both -- I just didn't check my FasterXML gmail account before adding comment. We are all good.

@cowtowncoder cowtowncoder added cla-received PR already covered by CLA (optional label) and removed cla-needed PR looks good (although may also require code review), but CLA needed from submitter labels Dec 2, 2025
@cowtowncoder
Copy link
Member

CLA received, can now merge (later today)

@cowtowncoder cowtowncoder merged commit 7c481d4 into FasterXML:3.x Dec 2, 2025
6 checks passed
cowtowncoder added a commit that referenced this pull request Dec 2, 2025
@cowtowncoder cowtowncoder added this to the 3.1.0 milestone Dec 2, 2025
@cowtowncoder
Copy link
Member

Just to make sure: both "info" and "cla" addresses work and end up in same place. But I updated CONTRIBUTING.md to have cla just for consistency.

Thank you again @nrayburn-tech !

@nrayburn-tech nrayburn-tech deleted the additional-jackson2-config branch December 2, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.1 cla-received PR already covered by CLA (optional label)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants