-
-
Notifications
You must be signed in to change notification settings - Fork 822
Additional configuration to closer match Jackson 2 behavior #1514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional configuration to closer match Jackson 2 behavior #1514
Conversation
| public B configureForJackson2() { | ||
| return disable(StreamReadFeature.USE_FAST_DOUBLE_PARSER) | ||
| .disable(StreamReadFeature.USE_FAST_BIG_NUMBER_PARSER); | ||
| return enable(StreamReadFeature.INCLUDE_SOURCE_IN_LOCATION) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, in Jackson 2.20 it is already disabled:
*
* @since 2.9 (but different default since 2.16)
*/
INCLUDE_SOURCE_IN_LOCATION(false),
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this javadoc is wrong in 2.x,
| * Feature is enabled by default, meaning that "source reference" information is passed |
Removed this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah. I'll fix Javadoc then.
4f3c662 to
3346679
Compare
|
Ok, one process thing: we'll need CLA (just once) before I can merge this (I did merge the other one first before remembering to ask for one). Just needs to be sent once, good for all future contributions: https://github.com/FasterXML/jackson/blob/main/contributor-agreement.pdf the usual way is to print, fill & sign, scan/photo, email to Once we got it, will merge. Thank you again! |
|
I sent it a bit ago before the first PR was created, so you should have it. If not, let me know and I can resend it. |
|
Looks like the contributing doc has a different email address, Just resent it to the |
|
@nrayburn-tech Sorry, got them both -- I just didn't check my FasterXML gmail account before adding comment. We are all good. |
|
CLA received, can now merge (later today) |
|
Just to make sure: both "info" and "cla" addresses work and end up in same place. But I updated Thank you again @nrayburn-tech ! |
No description provided.