Use bitset in VTKHDF read mesh, removing MPI_Allgatherv call. #3764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Addresses issue #3701 |
Member
|
I think a medium term fix would be that the mesh construction/factory function takes only the cell types on the calling process. Then this issue (largely) disappears. Once the mesh topology is built, information on the cell polynomial degree can be communicated (at the same time that the geometry data is communicated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than communicating all mesh cell types globally using
MPI_Allgathervuse a bitset to do a set union on the cell type and degree. Using 8 cell types, and degrees 1-8, this fits into a 64-bit bitset.