Fixed bug in chunk writing in spi_nor_write #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spi_nor_write returned bytes written (retlen) from the last call to nor->write If nor->write was called several times the returned retlen would be smaller than expected by jffs2, even if writing was successful. The following message would appear: jffs2: Write of 183 bytes at 0x003e02ac failed. returned 0, retlen 167
Some drivers implementing nor->write might not reset *retlen every time nor-write is called, thus accumulating bytes written. We can zero *retlen here since we are counting bytes written in retlen_l*/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spi_nor_write returned bytes written (retlen) from the last call to nor->write
If nor->write was called several times the returned retlen would be smaller than expected by jffs2, even if writing was successful.
The following message would appear:
jffs2: Write of 183 bytes at 0x003e02ac failed. returned 0, retlen 167