GH-973 Rename and restructure placeholders configuration classes #1225
+42
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChudziudgiToJa
requested review from
CitralFlo,
Jakubk15,
P1otrulla,
Pawelusze,
Qbiterv,
Rollczi,
VerniQ,
igoyek,
imDMK,
mydelkonivea,
noyzys and
vLuckyyy
ChudziudgiToJa
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request successfully refactors the placeholder configuration by moving it from a separate file into the main config.yml. This is a good move for consolidation and simplifies management. The introduction of the PlaceholdersSettings interface is a great choice for decoupling the configuration from its usage. The overall implementation is solid. I have one minor suggestion to improve code clarity and maintainability.
eternalcore-core/src/main/java/com/eternalcode/core/placeholder/PlaceholdersConfig.java
Show resolved
Hide resolved
ChudziudgiToJa
requested review from
CitralFlo and
imDMK
and removed request for
CitralFlo,
P1otrulla,
Pawelusze,
Qbiterv,
Rollczi,
VerniQ,
igoyek,
imDMK,
mydelkonivea and
noyzys
noyzys
reviewed
Oct 30, 2025
eternalcore-core/src/main/java/com/eternalcode/core/placeholder/PlaceholdersSettings.java
Show resolved
Hide resolved
eternalcore-core/src/main/java/com/eternalcode/core/placeholder/PlaceholdersSetup.java
Show resolved
Hide resolved
imDMK
reviewed
Oct 30, 2025
eternalcore-core/src/main/java/com/eternalcode/core/placeholder/PlaceholdersConfig.java
Show resolved
Hide resolved
|
|
||
| import java.util.Map; | ||
|
|
||
| public interface PlaceholdersSettings { |
Contributor
There was a problem hiding this comment.
I think an interface isn’t needed here. This is just a placeholders config, and at this point, I’m overengineering it.
Jakubk15
approved these changes
Nov 2, 2025
eternalcore-core/src/main/java/com/eternalcode/core/placeholder/PlaceholdersConfig.java
Show resolved
Hide resolved
CitralFlo
approved these changes
Nov 2, 2025
Member
|
Follow other reviews - nothing to add (Commander keeps tagging me) |
# Conflicts: # eternalcore-core/src/main/java/com/eternalcode/core/configuration/implementation/PluginConfiguration.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.