Display local scene #444
Open
Display local scene #444
+265
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubham7109
requested changes
Nov 27, 2025
Collaborator
shubham7109
left a comment
shubham7109
left a comment
There was a problem hiding this comment.
@colinanderson Nice work, sample app seems to work on physical device but not an emulator Pixel v36.
I added few minor clarity feedback. Feel free to update the arcgisMapsKotlinVersion within the libs.versions.toml to reflect any starting build in which LocalSceneView is available using toolkit.
|
|
||
| ## How it works | ||
|
|
||
| 1. Create a local scene object with the `ArcGISScene.ArcGISScene(arcGISTopographic, SceneViewingMode.local)` constructor. |
Collaborator
There was a problem hiding this comment.
I think this is a typo:
Suggested change
| 1. Create a local scene object with the `ArcGISScene.ArcGISScene(arcGISTopographic, SceneViewingMode.local)` constructor. | |
| 1. Create a local scene object with the `ArcGISScene(arcGISTopographic, SceneViewingMode.local)` constructor. |
| baseSurface.elevationSources.add(elevationSource) | ||
|
|
||
| initialViewpoint = Viewpoint( | ||
| center = Point(19455026.8116, -5054995.7415, SpatialReference.webMercator()), |
Collaborator
There was a problem hiding this comment.
Nitpick suggestion to use named args to readability:
Suggested change
| center = Point(19455026.8116, -5054995.7415, SpatialReference.webMercator()), | |
| center = Point( | |
| x = 19455026.8116, | |
| y = -5054995.7415, | |
| spatialReference = SpatialReference.webMercator() | |
| ), |
Comment on lines
+72
to
+76
| locationPoint = Point( | ||
| 19455578.6821, | ||
| -5056336.2227, | ||
| 1699.3366, | ||
| SpatialReference.webMercator()), |
Collaborator
There was a problem hiding this comment.
Same as above:
Suggested change
| locationPoint = Point( | |
| 19455578.6821, | |
| -5056336.2227, | |
| 1699.3366, | |
| SpatialReference.webMercator()), | |
| locationPoint = Point( | |
| x = 19455578.6821, | |
| y = -5056336.2227, | |
| z = 1699.3366, | |
| spatialReference = SpatialReference.webMercator() | |
| ), |
| LocalSceneView( | ||
| modifier = Modifier | ||
| .fillMaxSize() | ||
| .weight(1f), |
Collaborator
There was a problem hiding this comment.
Not needed for the Column :)
Suggested change
| .weight(1f), | |
| , |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR to add a new Kotlin sample "Display Local Scene" in
Scenescategory.Links and Data
What To Review
README.mdandREADME.metadata.jsonfilesHow to Test
Run the sample on the sample viewer or the repo.
Screenshots