Skip to content

engflow_auth: add --insecure flag to "login" #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
laszlocsomor merged 2 commits into from
Sep 25, 2025
Merged

engflow_auth: add --insecure flag to "login" #72

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c21fff
engflow_auth: add --insecure flag to "login"
laszlocsomor Sep 24, 2025
b5fc012
add a warning
laszlocsomor Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion cmd/engflow_auth/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,14 @@ package main

import (
"context"
"crypto/tls"
"encoding/json"
"errors"
"fmt"
"io"
"io/fs"
"net"
"net/http"
"net/url"
"os"
"os/signal"
Expand Down Expand Up @@ -224,6 +226,18 @@ func (r *appState) import_(cliCtx *cli.Context) error {
func (r *appState) login(cliCtx *cli.Context) error {
ctx := cliCtx.Context

if cliCtx.Bool("insecure") {
fmt.Fprintf(cliCtx.App.ErrWriter, "Warning: server TLS validation is disabled\n")
httpClient := &http.Client{
Transport: &http.Transport{
TLSClientConfig: &tls.Config{
InsecureSkipVerify: true,
},
},
}
ctx = context.WithValue(ctx, oauth2.HTTPClient, httpClient)
}

if cliCtx.NArg() != 1 {
return autherr.CodedErrorf(autherr.CodeBadParams, "expected exactly 1 positional argument, a cluster name")
}
Expand Down Expand Up @@ -349,6 +363,10 @@ func makeApp(root *appState) *cli.App {
Name: "alias",
Usage: "Comma-separated list of alias hostnames for this cluster",
}
insecureFlag := &cli.BoolFlag{
Name: "insecure",
Usage: "Disable server TLS validation",
}

app := &cli.App{
Name: "engflow_auth",
Expand Down Expand Up @@ -386,7 +404,7 @@ credential helper protocol.`),
Initiates an interactive OAuth2 flow to log into the cluster at
CLUSTER_URL.`),
Action: root.login,
Flags: []cli.Flag{aliasFlag, storeFlag},
Flags: []cli.Flag{aliasFlag, storeFlag, insecureFlag},
},
{
Name: "logout",
Expand Down