Cleanup & Consistency #939
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not needed for compatibility since SocketIoFacade is internal
There was a problem hiding this comment.
Pull Request Overview
This PR improves code consistency and removes redundant code across the ElectronNET solution. The changes focus on standardizing nullable reference type settings and cleaning up the SocketIOFacade implementation.
- Disables nullable reference types across three additional project files for consistency with the existing codebase
- Removes a redundant method overload in SocketIOFacade that was superseded by the generic version
- Reorganizes using statements to follow standard conventions
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/ElectronNET/ElectronNET.csproj | Adds <Nullable>disable</Nullable> to align with other library projects in the solution |
| src/ElectronNET.WebApp/ElectronNET.WebApp.csproj | Adds <Nullable>disable</Nullable> to align with other library projects in the solution |
| src/ElectronNET.ConsoleApp/ElectronNET.ConsoleApp.csproj | Adds <Nullable>disable</Nullable> to align with other library projects in the solution |
| src/ElectronNET.API/Bridge/SocketIOFacade.cs | Removes redundant On(string, Action<object>) method and reorganizes using statements to follow standard conventions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.