Demo fixes #912
Draft
Demo fixes #912
+1,601
−57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
This where quick findings, I'll try debug them later |
It doesn't make sense to do this adjustment for set only but not for get. Neither is this done for SetBounds, so it should be either fully consistent or left up to the application to deal with it.
The options were no propagated for the overload with RemovePassword options
It's a method, was used like a property
It's not supported on all platforms
softworkz
reviewed
Nov 9, 2025
| return; | ||
| } | ||
|
|
||
| // FIXME: At launch the newState is 'Started' and this.state is 'Ready' throwing always an error |
softworkz
reviewed
Nov 9, 2025
| { | ||
| if(HybridSupport.IsElectronActive) | ||
| { | ||
| // FIXME: System.TimeoutException: 'No response after 1000ms trying to retrieve value app.GetAppPathAsync()' |
softworkz
reviewed
Nov 9, 2025
| Electron.AutoUpdater.OnUpdateDownloaded += async (info) => await Electron.Dialog.ShowMessageBoxAsync("Update complete!" + info.Version); | ||
|
|
||
|
|
||
| // FIXME: System.TimeoutException: 'No response after 1000ms trying to retrieve value app.GetVersionAsync()' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not very familiar with the codebase yet, especially since I still need to go through all the TS/JS parts. While looking at the develop branch (the one without the migration to System.Text.Json), I added some comments to point out what isn't working in the demo. I figured that if someone with more experience in the codebase is interested, they could help fix those issues, so we can have a solid base to work from when attempting the migration in the future.