Splitted ws server from httpd (i.e concurrent nino) and allow to disable ssl support at compilation time. #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ws server code relies on httpd library. Added a way to disable ssl support at compilation time for httpd library, and then ws server.
Member
Author
|
do not pull, this is for now, just for review |
code cleaning, renaming.
Changed the structure of the package, to follow similar logic for server and client.
Member
There was a problem hiding this comment.
Why not keep WEB_SOCKET_ prefix, to be consistent with the previous changes?
Member
Author
There was a problem hiding this comment.
I think that all classes on protocol and server side are prefixed WS_ ... so I tried to apply that for constants as well.
maybe I am wrong, I don't really mind to use WEB_SOCKET_ prefix instead.
we just need to be consistent.
For the client, I kept this prefix, because WS_SOCKET .. was a bit weird, but could also be possible
Member
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitted ws server from httpd (i.e concurrent nino).
ws server code relies on httpd library.
Added a way to disable ssl support at compilation time for httpd library, and then ws server.