Skip to content

fix: strlen is not constexpr #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mathieucarbou merged 2 commits into from
Dec 8, 2025
Merged

fix: strlen is not constexpr #354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f58f7a
fix: strlen is not constexpr
proxict Dec 6, 2025
ac4c378
Use sizeof() instead of strlen() where possible
proxict Dec 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/WebRequest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1001,7 +1001,7 @@ void AsyncWebServerRequest::requestAuthentication(AsyncAuthType method, const ch
case AsyncAuthType::AUTH_BASIC:
{
String header;
if (header.reserve(strlen(T_BASIC_REALM) + strlen(realm) + 1)) {
if (header.reserve(sizeof(T_BASIC_REALM) - 1 + strlen(realm) + 1)) {
header.concat(T_BASIC_REALM);
header.concat(realm);
header.concat('"');
Expand All @@ -1015,7 +1015,7 @@ void AsyncWebServerRequest::requestAuthentication(AsyncAuthType method, const ch
}
case AsyncAuthType::AUTH_DIGEST:
{
size_t len = strlen(T_DIGEST_) + strlen(T_realm__) + strlen(T_auth_nonce) + 32 + strlen(T__opaque) + 32 + 1;
size_t len = sizeof(T_DIGEST_) - 1 + sizeof(T_realm__) - 1 + sizeof(T_auth_nonce) - 1 + 32 + sizeof(T__opaque) - 1 + 32 + 1;
String header;
if (header.reserve(len + strlen(realm))) {
const String nonce = genRandomMD5();
Expand Down
4 changes: 2 additions & 2 deletions src/WebResponses.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -756,7 +756,7 @@ AsyncFileResponse::AsyncFileResponse(FS &fs, const String &path, const char *con
int filenameStart = path.lastIndexOf('/') + 1;
const char *filename = path.c_str() + filenameStart;
String buf;
buf.reserve(strlen(T_attachment) + strlen(filename) + 2);
buf.reserve(sizeof(T_attachment) - 1 + strlen(filename) + 2);
buf = T_attachment;
buf += filename;
buf += "\"";
Expand Down Expand Up @@ -794,7 +794,7 @@ AsyncFileResponse::AsyncFileResponse(File content, const String &path, const cha
int filenameStart = path.lastIndexOf('/') + 1;
const char *filename = path.c_str() + filenameStart;
String buf;
buf.reserve(strlen(T_attachment) + strlen(filename) + 2);
buf.reserve(sizeof(T_attachment) - 1 + strlen(filename) + 2);
buf = T_attachment;
buf += filename;
buf += "\"";
Expand Down
Loading