Add scriptCompletionQuit option
#297
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #290
The documentation changes have been submitted at Dinomite-Studios/unity-azure-pipelines-tasks-docs#20
Problem
I've been using this script in a professional environment and have encountered a specific situation where I essentially have to create an asynchronous task to wait for Unity to finish some background processes.
The problem is that when
buildScriptTypeis set toexisting, the-quitargument is appended to the Unity command, causing Unity to close before my method is actually completed.Solution
This PR adds a
scriptCompletionQuitoption that is optional and defaults to the current behavior (automatically quitting after the method is completed).Those who want to perform advanced actions with their method can set it to
false, and are responsible for closing Unity from the desired location, at the desired time.