-
Notifications
You must be signed in to change notification settings - Fork 2
chore: upgrade wasmtime to latest (39.0.1) to work with ruby 3.4.7 #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9854418 to
cbb1f08
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR upgrades the wasmtime dependency from version 20.0.2 to 39.0.1 to ensure compatibility with Ruby 3.4.7. The upgrade requires updates to the WASM initialization code to align with breaking API changes in the newer wasmtime version.
Key changes:
- Updates wasmtime dependency version in gemspec
- Refactors WASM initialization to use new wasmtime API patterns (WasiConfig, wasi_p1_config, and P1.add_to_linker_sync)
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| devcycle-ruby-server-sdk.gemspec | Updates wasmtime dependency from 20.0.2 to 39.0.1 |
| lib/devcycle-ruby-server-sdk/localbucketing/local_bucketing.rb | Refactors WASM initialization code to use new wasmtime API (WasiConfig instead of WasiCtxBuilder, updated Store and Linker initialization) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cbb1f08 to
a9e2c5a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…enfeature provider fetch_integer_value method
06a2559 to
ed1122a
Compare
wasmtimeto39.0.1(Dec 05, 2025 release)ruby/setup-ruby@v1.264.0to support up toruby 3.4.7and addsruby 3.4.1to unit test workflow on GH Actionsfetch_integer_valuemethod in the OpenFeature provider to always cast the response to integer and return it0.4.1