fix: revert if statement logic #124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaushalkapasi
approved these changes
Jul 31, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an error handling condition in the variable_with_http_info method that had its logic inadvertently inverted. The condition now correctly logs errors for non-404 HTTP status codes, while silently handling the expected 404 case.
Key Changes:
- Corrected the error logging condition from
== 404to!= 404to log only unexpected API errors
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kaushalkapasi
force-pushed
the
fix-log
branch
from
e0665b3 to
3198e9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes