fix: mark SSE connection as connected when Comment events are received #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also adjust default polling time to be 30 seconds
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where the SDK was falling back to a 1-second polling interval due to unhandled SSE Comment events. The changes address this by handling Comment events and increasing the default polling interval to 30 seconds.
Key changes:
- Added handling for
ld_eventsource.actions.Commentevents in the SSE manager - Increased default
config_polling_interval_msfrom 1000ms to 30000ms
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| devcycle_python_sdk/options.py | Increases the default polling interval from 1 second to 30 seconds to reduce unnecessary polling when SSE is connected |
| devcycle_python_sdk/managers/sse_manager.py | Adds Comment event handling to mark SSE connection as active and prevent fallback to short polling intervals |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JamieSinn
approved these changes
Dec 4, 2025
luxscious
deleted the
tso-331-python-sdk-polling-for-config-every-1-second-when-sse
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ld-eventsource was emitting comment events that we weren’t handling, causing the SDK to fall back to a 1s SSE polling interval when no polling options were set.
fix: handle comment events.
fix: increase base polling time to 30 seconds.