-
Notifications
You must be signed in to change notification settings - Fork 6
chore: change openfeature requirement to compatible patch versions #102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot wasn't able to review any files in this pull request.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 3 out of 5 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 3 out of 5 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 3 out of 5 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 4 out of 6 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
devcycle_python_sdk/open_feature_provider/provider.py:151
- The condition logic is incorrect. The expression
not isinstance(v, (str, int, float, bool)) or v is Nonewill always be True when v is None, causing valid None values to raise an error. It should benot isinstance(v, (str, int, float, bool, type(None)))orv is not None and not isinstance(v, (str, int, float, bool)).
if not isinstance(v, (str, int, float, bool)) or v is None:
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 4 out of 6 changed files in this pull request and generated 12 comments.
Comments suppressed due to low confidence (1)
devcycle_python_sdk/open_feature_provider/provider.py:151
- The logic is incorrect. The condition
or v is Nonewill always raise TypeMismatchError when v is None because the first part evaluates to True when v is None. Should beif not isinstance(v, (str, int, float, bool, type(None)))orif v is not None and not isinstance(v, (str, int, float, bool)).
if not isinstance(v, (str, int, float, bool)) or v is None:
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Changes