Multi-Sided Sign Support #2796
Open
Multi-Sided Sign Support #2796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nism. Added back-of-sign support to CopyBlock command
davight
reviewed
Dec 1, 2025
| else { | ||
| for (Component component : sign.lines()) { | ||
| output[i++] = PaperModule.stringifyComponent(component); | ||
| } |
Contributor
There was a problem hiding this comment.
this probably could be ternary in the for-each statement, since the body is the same
davight
reviewed
Dec 1, 2025
| } | ||
| CoreUtilities.fixNewLinesToListSeparation(input); | ||
| if (input.size() > 4) { | ||
| mechanism.echoError("Sign can only hold four lines!"); |
Contributor
There was a problem hiding this comment.
isnt this missing return statement?
davight
reviewed
Dec 1, 2025
| for (int i = 0; i < 4; i++) { | ||
| PaperAPITools.instance.setSignLine(sign, i, ""); | ||
| } | ||
| ListTag list = mechanism.valueAsType(ListTag.class); |
Contributor
There was a problem hiding this comment.
is this required? sign_contents_back doesnt have it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Text on the back of signs was added in MC 1.20. This PR adds in the following:
ItemTag.sign_contents, it will only look at the sign contents for the front of the sign across versions. A line in the meta references the new property below for information about the back of signs.ItemTag.sign_contents_backfor MC 1.20+.LocationTag.sign_contents, it will only look at the sign contents for the front of the sign across versions. A line in the meta references the new tag and mechanism below for information about the back of signs.LocationTag.sign_contents_backfor MC 1.20+.copyblockcommand on MC 1.20+.