Skip to content

fix: enable uwsgi EXTRA_ARGS passthrough #13756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
+1 −1
Open

fix: enable uwsgi EXTRA_ARGS passthrough #13756

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9eb305f
fix: enable uwsgi EXTRA_ARGS passthrough
Bump-Action Nov 22, 2025
f506013
Merge branch 'dev' into uwsgi-extra-args
Bump-Action Nov 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docker/entrypoint-uwsgi.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ python3 manage.py check

DD_UWSGI_LOGFORMAT_DEFAULT='[pid: %(pid)|app: -|req: -/-] %(addr) (%(dd_user)) {%(vars) vars in %(pktsize) bytes} [%(ctime)] %(method) %(uri) => generated %(rsize) bytes in %(msecs) msecs (%(proto) %(status)) %(headers) headers in %(hsize) bytes (%(switches) switches on core %(core))'

EXTRA_ARGS=""
EXTRA_ARGS="${EXTRA_ARGS:-}"
Copy link
Contributor

@kiblik kiblik Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it better to call it DD_UWSGI_EXTRA_ARGS? As soon as EXTRA_ARGS appears in some configuration, it might be confusing: Extra args of what?

Copy link
Member

@valentijnscholten valentijnscholten Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed. I thought EXTRA_ARGS was some well-known way to startup uwsgi, but it's DD specific.

Copy link
Contributor

@mtesauro mtesauro Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

if [ -n "${DD_UWSGI_MAX_FD}" ]; then
EXTRA_ARGS="${EXTRA_ARGS} --max-fd ${DD_UWSGI_MAX_FD}"
fi
Expand Down