Skip to content

Fix Duplicate Findings in Github SAST Scan by Improving Hash Code #13683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from
Draft

Fix Duplicate Findings in Github SAST Scan by Improving Hash Code #13683

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
459c46b
Remove line and add url to hash code
Logicmn Nov 11, 2025
7945fc0
Add comment to parser docs about edge cases
Logicmn Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/content/supported_tools/parsers/file/github_sast.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,7 @@ toc_hide: true
Import findings in JSON format from Github Code Scanning REST API:
<https://docs.github.com/en/rest/code-scanning/code-scanning>

It is important to note that DefectDojo creates a hash code for Github SAST Scan findings based on the `html_url` field in the uploaded alert. If your organization goes through an Enterprise Managed Users (EMU) migration, or an Enterprise Cloud or Serve migration, this field could change. This would cause some duplication in findings.

### Sample Scan Data
Sample Github SAST scans can be found [here](https://github.com/DefectDojo/django-DefectDojo/tree/master/unittests/scans/github_sast).
2 changes: 1 addition & 1 deletion dojo/settings/settings.dist.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1354,7 +1354,7 @@
"JFrog Xray On Demand Binary Scan": ["title", "component_name", "component_version"],
"Scout Suite Scan": ["file_path", "vuln_id_from_tool"], # for now we use file_path as there is no attribute for "service"
"Meterian Scan": ["cwe", "component_name", "component_version", "description", "severity"],
"Github SAST Scan": ["vuln_id_from_tool", "severity", "file_path", "line"],
"Github SAST Scan": ["vuln_id_from_tool", "severity", "file_path", "url"], # url is the github alert url

Check failure on line 1357 in dojo/settings/settings.dist.py

View workflow job for this annotation

GitHub Actions / ruff-linting

Ruff (E261) 

dojo/settings/settings.dist.py:1357:79: E261 Insert at least two spaces before an inline comment
"Github Vulnerability Scan": ["title", "severity", "component_name", "vulnerability_ids", "file_path"],
"Github Secrets Detection Report": ["title", "file_path", "line"],
"Solar Appscreener Scan": ["title", "file_path", "line", "severity"],
Expand Down
Loading