Cleanup classpath for modules with dependency on Groovy and Spock #10069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexeyKuznetsov-DD
added
tag: no release notes
AlexeyKuznetsov-DD
requested review from
daniel-mohedano,
jandro996 and
manuel-alvarez-alvarez
sarahchen6
reviewed
Dec 3, 2025
| addTestSuiteForDir('latestDepTest', 'test') | ||
|
|
||
| dependencies { | ||
| testImplementation(libs.javaparser) |
Contributor
There was a problem hiding this comment.
just wondering -- do you know why this previously didn't need to be included?
I see that you also included libs.javaparser with your changes in gradle/libs.versions.toml, but if I understand correctly, this library wasn't a part of groovy-all
Contributor
Author
There was a problem hiding this comment.
Actually it is from groovy-all:
./gradlew :dd-java-agent:instrumentation:java:java-lang:java-lang-15.0:dependencies
Part of the tree:
org.codehaus.groovy:groovy-all:3.0.24
| +--- org.codehaus.groovy:groovy-groovydoc:3.0.24
| | +--- org.codehaus.groovy:groovy:3.0.24
| | \--- com.github.javaparser:javaparser-core:3.25.6
And there usage in tests:
import com.github.javaparser.utils.StringEscapeUtils
Contributor
Author
There was a problem hiding this comment.
This PR make that obvious, that we NEVER used groovydoc, but its transitive dependency :)
sarahchen6
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
groovy-alldependency with individualgroovy-*modules.GroovyandSpockdependencies so they are used only within the test scope.Motivation
Using the bundled
groovy-allartifact introduces a large set of transitive dependencies into the classpath, many of which are unnecessary. Splitting it into specificgroovy-*modules helps reduce classpath footprint and improves build hygiene.Additionally, several modules previously declared
GroovyandSpockasapidependencies, even when they were only required for testing. This PR corrects that by limiting their usage to the appropriate scope.Additional Notes
Approximately 95% of modules already use
GroovyandSpockviatestImplementation. The remaining modules have been adjusted manually to prevent unneeded classpath pollution.