-
Notifications
You must be signed in to change notification settings - Fork 319
Adding Config Registry Linter to Ensure Alias Keys Are Documented #10068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
buildSrc/src/main/kotlin/datadog/gradle/plugin/config/ConfigInversionLinter.kt
Show resolved
Hide resolved
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 8 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~f907aa74c8, baseline=1.57.0-SNAPSHOT~c714e59b1ca
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.053 s) : 0, 1053331
Total [baseline] (10.795 s) : 0, 10795241
Agent [candidate] (1.057 s) : 0, 1056910
Total [candidate] (10.868 s) : 0, 10868327
section appsec
Agent [baseline] (1.23 s) : 0, 1230028
Total [baseline] (10.986 s) : 0, 10986346
Agent [candidate] (1.227 s) : 0, 1226949
Total [candidate] (10.872 s) : 0, 10871686
section iast
Agent [baseline] (1.202 s) : 0, 1201907
Total [baseline] (11.173 s) : 0, 11173408
Agent [candidate] (1.194 s) : 0, 1194127
Total [candidate] (11.173 s) : 0, 11173169
section profiling
Agent [baseline] (1.199 s) : 0, 1198634
Total [baseline] (10.886 s) : 0, 10885699
Agent [candidate] (1.206 s) : 0, 1205916
Total [candidate] (10.897 s) : 0, 10897342
gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~f907aa74c8, baseline=1.57.0-SNAPSHOT~c714e59b1ca
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.489 ms) : 0, 1489
crashtracking [candidate] (1.478 ms) : 0, 1478
BytebuddyAgent [baseline] (708.195 ms) : 0, 708195
BytebuddyAgent [candidate] (710.537 ms) : 0, 710537
GlobalTracer [baseline] (249.353 ms) : 0, 249353
GlobalTracer [candidate] (250.192 ms) : 0, 250192
AppSec [baseline] (32.206 ms) : 0, 32206
AppSec [candidate] (32.325 ms) : 0, 32325
Debugger [baseline] (6.376 ms) : 0, 6376
Debugger [candidate] (6.462 ms) : 0, 6462
Remote Config [baseline] (672.345 µs) : 0, 672
Remote Config [candidate] (691.779 µs) : 0, 692
Telemetry [baseline] (14.545 ms) : 0, 14545
Telemetry [candidate] (15.46 ms) : 0, 15460
Flare Poller [baseline] (5.694 ms) : 0, 5694
Flare Poller [candidate] (4.829 ms) : 0, 4829
section appsec
crashtracking [baseline] (1.475 ms) : 0, 1475
crashtracking [candidate] (1.471 ms) : 0, 1471
BytebuddyAgent [baseline] (733.226 ms) : 0, 733226
BytebuddyAgent [candidate] (730.703 ms) : 0, 730703
GlobalTracer [baseline] (241.931 ms) : 0, 241931
GlobalTracer [candidate] (241.492 ms) : 0, 241492
IAST [baseline] (24.777 ms) : 0, 24777
IAST [candidate] (24.726 ms) : 0, 24726
AppSec [baseline] (174.798 ms) : 0, 174798
AppSec [candidate] (174.622 ms) : 0, 174622
Debugger [baseline] (6.192 ms) : 0, 6192
Debugger [candidate] (6.249 ms) : 0, 6249
Remote Config [baseline] (674.459 µs) : 0, 674
Remote Config [candidate] (682.922 µs) : 0, 683
Telemetry [baseline] (7.974 ms) : 0, 7974
Telemetry [candidate] (8.028 ms) : 0, 8028
Flare Poller [baseline] (3.997 ms) : 0, 3997
Flare Poller [candidate] (3.997 ms) : 0, 3997
section iast
crashtracking [baseline] (1.485 ms) : 0, 1485
crashtracking [candidate] (1.483 ms) : 0, 1483
BytebuddyAgent [baseline] (839.246 ms) : 0, 839246
BytebuddyAgent [candidate] (832.617 ms) : 0, 832617
GlobalTracer [baseline] (238.738 ms) : 0, 238738
GlobalTracer [candidate] (238.217 ms) : 0, 238217
IAST [baseline] (29.423 ms) : 0, 29423
IAST [candidate] (29.845 ms) : 0, 29845
AppSec [baseline] (32.212 ms) : 0, 32212
AppSec [candidate] (31.568 ms) : 0, 31568
Debugger [baseline] (6.131 ms) : 0, 6131
Debugger [candidate] (6.068 ms) : 0, 6068
Remote Config [baseline] (622.877 µs) : 0, 623
Remote Config [candidate] (601.096 µs) : 0, 601
Telemetry [baseline] (8.122 ms) : 0, 8122
Telemetry [candidate] (8.034 ms) : 0, 8034
Flare Poller [baseline] (10.841 ms) : 0, 10841
Flare Poller [candidate] (10.934 ms) : 0, 10934
section profiling
crashtracking [baseline] (1.439 ms) : 0, 1439
crashtracking [candidate] (1.449 ms) : 0, 1449
BytebuddyAgent [baseline] (734.41 ms) : 0, 734410
BytebuddyAgent [candidate] (740.09 ms) : 0, 740090
GlobalTracer [baseline] (222.574 ms) : 0, 222574
GlobalTracer [candidate] (222.87 ms) : 0, 222870
AppSec [baseline] (32.159 ms) : 0, 32159
AppSec [candidate] (32.237 ms) : 0, 32237
Debugger [baseline] (6.884 ms) : 0, 6884
Debugger [candidate] (6.843 ms) : 0, 6843
Remote Config [baseline] (688.226 µs) : 0, 688
Remote Config [candidate] (674.571 µs) : 0, 675
Telemetry [baseline] (16.001 ms) : 0, 16001
Telemetry [candidate] (16.25 ms) : 0, 16250
Flare Poller [baseline] (4.171 ms) : 0, 4171
Flare Poller [candidate] (4.188 ms) : 0, 4188
ProfilingAgent [baseline] (111.017 ms) : 0, 111017
ProfilingAgent [candidate] (111.756 ms) : 0, 111756
Profiling [baseline] (111.643 ms) : 0, 111643
Profiling [candidate] (112.389 ms) : 0, 112389
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~f907aa74c8, baseline=1.57.0-SNAPSHOT~c714e59b1ca
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.061 s) : 0, 1061216
Total [baseline] (8.693 s) : 0, 8693421
Agent [candidate] (1.05 s) : 0, 1049631
Total [candidate] (8.669 s) : 0, 8669260
section iast
Agent [baseline] (1.191 s) : 0, 1191391
Total [baseline] (9.347 s) : 0, 9347046
Agent [candidate] (1.203 s) : 0, 1202807
Total [candidate] (9.39 s) : 0, 9390359
gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~f907aa74c8, baseline=1.57.0-SNAPSHOT~c714e59b1ca
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.495 ms) : 0, 1495
crashtracking [candidate] (1.489 ms) : 0, 1489
BytebuddyAgent [baseline] (714.503 ms) : 0, 714503
BytebuddyAgent [candidate] (706.157 ms) : 0, 706157
GlobalTracer [baseline] (250.567 ms) : 0, 250567
GlobalTracer [candidate] (248.033 ms) : 0, 248033
AppSec [baseline] (32.232 ms) : 0, 32232
AppSec [candidate] (31.853 ms) : 0, 31853
Debugger [baseline] (6.454 ms) : 0, 6454
Debugger [candidate] (6.334 ms) : 0, 6334
Remote Config [baseline] (674.179 µs) : 0, 674
Remote Config [candidate] (669.064 µs) : 0, 669
Telemetry [baseline] (13.983 ms) : 0, 13983
Telemetry [candidate] (15.322 ms) : 0, 15322
Flare Poller [baseline] (6.279 ms) : 0, 6279
Flare Poller [candidate] (4.939 ms) : 0, 4939
section iast
crashtracking [baseline] (1.481 ms) : 0, 1481
crashtracking [candidate] (1.497 ms) : 0, 1497
BytebuddyAgent [baseline] (830.132 ms) : 0, 830132
BytebuddyAgent [candidate] (840.883 ms) : 0, 840883
GlobalTracer [baseline] (237.543 ms) : 0, 237543
GlobalTracer [candidate] (237.93 ms) : 0, 237930
IAST [baseline] (29.357 ms) : 0, 29357
IAST [candidate] (32.17 ms) : 0, 32170
AppSec [baseline] (32.225 ms) : 0, 32225
AppSec [candidate] (29.817 ms) : 0, 29817
Debugger [baseline] (6.092 ms) : 0, 6092
Debugger [candidate] (6.045 ms) : 0, 6045
Remote Config [baseline] (606.931 µs) : 0, 607
Remote Config [candidate] (612.824 µs) : 0, 613
Telemetry [baseline] (8.036 ms) : 0, 8036
Telemetry [candidate] (8.114 ms) : 0, 8114
Flare Poller [baseline] (10.885 ms) : 0, 10885
Flare Poller [candidate] (10.713 ms) : 0, 10713
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 4 performance regressions! Performance is the same for 16 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~f907aa74c8, baseline=1.57.0-SNAPSHOT~c714e59b1ca
dateFormat X
axisFormat %s
section baseline
no_agent (1.194 ms) : 1183, 1206
. : milestone, 1194,
iast (3.237 ms) : 3192, 3282
. : milestone, 3237,
iast_FULL (5.796 ms) : 5738, 5855
. : milestone, 5796,
iast_GLOBAL (3.471 ms) : 3412, 3530
. : milestone, 3471,
profiling (1.932 ms) : 1916, 1948
. : milestone, 1932,
tracing (1.803 ms) : 1788, 1818
. : milestone, 1803,
section candidate
no_agent (1.208 ms) : 1196, 1220
. : milestone, 1208,
iast (3.349 ms) : 3302, 3397
. : milestone, 3349,
iast_FULL (5.671 ms) : 5616, 5727
. : milestone, 5671,
iast_GLOBAL (3.625 ms) : 3572, 3678
. : milestone, 3625,
profiling (1.991 ms) : 1974, 2009
. : milestone, 1991,
tracing (1.812 ms) : 1797, 1828
. : milestone, 1812,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~f907aa74c8, baseline=1.57.0-SNAPSHOT~c714e59b1ca
dateFormat X
axisFormat %s
section baseline
no_agent (18.132 ms) : 17947, 18318
. : milestone, 18132,
appsec (18.586 ms) : 18399, 18773
. : milestone, 18586,
code_origins (17.607 ms) : 17431, 17783
. : milestone, 17607,
iast (17.755 ms) : 17576, 17935
. : milestone, 17755,
profiling (18.331 ms) : 18149, 18513
. : milestone, 18331,
tracing (17.786 ms) : 17606, 17966
. : milestone, 17786,
section candidate
no_agent (17.804 ms) : 17625, 17983
. : milestone, 17804,
appsec (18.286 ms) : 18102, 18470
. : milestone, 18286,
code_origins (17.656 ms) : 17479, 17833
. : milestone, 17656,
iast (18.898 ms) : 18706, 19091
. : milestone, 18898,
profiling (18.354 ms) : 18169, 18538
. : milestone, 18354,
tracing (18.535 ms) : 18351, 18719
. : milestone, 18535,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~f907aa74c8, baseline=1.57.0-SNAPSHOT~c714e59b1ca
dateFormat X
axisFormat %s
section baseline
no_agent (15.054 s) : 15054000, 15054000
. : milestone, 15054000,
appsec (14.746 s) : 14746000, 14746000
. : milestone, 14746000,
iast (18.477 s) : 18477000, 18477000
. : milestone, 18477000,
iast_GLOBAL (18.058 s) : 18058000, 18058000
. : milestone, 18058000,
profiling (14.566 s) : 14566000, 14566000
. : milestone, 14566000,
tracing (14.762 s) : 14762000, 14762000
. : milestone, 14762000,
section candidate
no_agent (14.954 s) : 14954000, 14954000
. : milestone, 14954000,
appsec (14.648 s) : 14648000, 14648000
. : milestone, 14648000,
iast (18.123 s) : 18123000, 18123000
. : milestone, 18123000,
iast_GLOBAL (18.008 s) : 18008000, 18008000
. : milestone, 18008000,
profiling (15.242 s) : 15242000, 15242000
. : milestone, 15242000,
tracing (14.747 s) : 14747000, 14747000
. : milestone, 14747000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~f907aa74c8, baseline=1.57.0-SNAPSHOT~c714e59b1ca
dateFormat X
axisFormat %s
section baseline
no_agent (1.482 ms) : 1470, 1494
. : milestone, 1482,
appsec (3.717 ms) : 3499, 3934
. : milestone, 3717,
iast (2.222 ms) : 2157, 2286
. : milestone, 2222,
iast_GLOBAL (2.262 ms) : 2197, 2327
. : milestone, 2262,
profiling (2.102 ms) : 2048, 2156
. : milestone, 2102,
tracing (2.066 ms) : 2014, 2117
. : milestone, 2066,
section candidate
no_agent (1.479 ms) : 1467, 1490
. : milestone, 1479,
appsec (3.648 ms) : 3433, 3863
. : milestone, 3648,
iast (2.215 ms) : 2150, 2279
. : milestone, 2215,
iast_GLOBAL (2.267 ms) : 2202, 2332
. : milestone, 2267,
profiling (2.104 ms) : 2050, 2158
. : milestone, 2104,
tracing (2.052 ms) : 2001, 2103
. : milestone, 2052,
|
What Does This Do
This PR adds a new Gradle task to ensure that all alias keys in the
supported-configurations.jsonfile are also defined and documented in thesupportedConfigurationskey.Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]