-
Notifications
You must be signed in to change notification settings - Fork 319
Combine client_drop_p0s support and agent version check for CSS
#10046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bric3
wants to merge
3
commits into
bdu/enable-css-only-after-agent-7.65.0
Choose a base branch
from
bdu/combine-p0drop-support-and-agent-version-check
base: bdu/enable-css-only-after-agent-7.65.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Combine client_drop_p0s support and agent version check for CSS
#10046
bric3
wants to merge
3
commits into
bdu/enable-css-only-after-agent-7.65.0
from
bdu/combine-p0drop-support-and-agent-version-check
+8
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amarziali
reviewed
Nov 27, 2025
communication/src/main/java/datadog/communication/ddagent/DDAgentFeaturesDiscovery.java
Outdated
Show resolved
Hide resolved
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 61 metrics, 4 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~cca1811515, baseline=1.57.0-SNAPSHOT~89639f7e8c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.09 s) : 0, 1090315
Total [baseline] (10.807 s) : 0, 10806983
Agent [candidate] (1.081 s) : 0, 1080935
Total [candidate] (10.81 s) : 0, 10809788
section appsec
Agent [baseline] (1.261 s) : 0, 1260928
Total [baseline] (11.124 s) : 0, 11123687
Agent [candidate] (1.266 s) : 0, 1266187
Total [candidate] (11.177 s) : 0, 11176835
section iast
Agent [baseline] (1.224 s) : 0, 1223694
Total [baseline] (11.175 s) : 0, 11174834
Agent [candidate] (1.226 s) : 0, 1226296
Total [candidate] (11.287 s) : 0, 11287061
section profiling
Agent [baseline] (1.207 s) : 0, 1206581
Total [baseline] (11.041 s) : 0, 11041035
Agent [candidate] (1.209 s) : 0, 1209258
Total [candidate] (11.025 s) : 0, 11025300
gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~cca1811515, baseline=1.57.0-SNAPSHOT~89639f7e8c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.2 ms) : 0, 1200
crashtracking [candidate] (1.193 ms) : 0, 1193
BytebuddyAgent [baseline] (653.75 ms) : 0, 653750
BytebuddyAgent [candidate] (648.539 ms) : 0, 648539
GlobalTracer [baseline] (284.463 ms) : 0, 284463
GlobalTracer [candidate] (282.036 ms) : 0, 282036
AppSec [baseline] (32.854 ms) : 0, 32854
AppSec [candidate] (32.423 ms) : 0, 32423
Debugger [baseline] (68.775 ms) : 0, 68775
Debugger [candidate] (67.873 ms) : 0, 67873
Remote Config [baseline] (655.28 µs) : 0, 655
Remote Config [candidate] (638.473 µs) : 0, 638
Telemetry [baseline] (9.129 ms) : 0, 9129
Telemetry [candidate] (8.979 ms) : 0, 8979
Flare Poller [baseline] (3.822 ms) : 0, 3822
Flare Poller [candidate] (3.72 ms) : 0, 3720
section appsec
crashtracking [baseline] (1.177 ms) : 0, 1177
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (687.095 ms) : 0, 687095
BytebuddyAgent [candidate] (690.309 ms) : 0, 690309
GlobalTracer [baseline] (258.597 ms) : 0, 258597
GlobalTracer [candidate] (259.701 ms) : 0, 259701
AppSec [baseline] (174.473 ms) : 0, 174473
AppSec [candidate] (174.734 ms) : 0, 174734
Debugger [baseline] (66.326 ms) : 0, 66326
Debugger [candidate] (66.685 ms) : 0, 66685
Remote Config [baseline] (720.165 µs) : 0, 720
Remote Config [candidate] (710.656 µs) : 0, 711
Telemetry [baseline] (8.788 ms) : 0, 8788
Telemetry [candidate] (8.947 ms) : 0, 8947
Flare Poller [baseline] (3.832 ms) : 0, 3832
Flare Poller [candidate] (3.779 ms) : 0, 3779
IAST [baseline] (24.47 ms) : 0, 24470
IAST [candidate] (24.648 ms) : 0, 24648
section iast
crashtracking [baseline] (1.188 ms) : 0, 1188
crashtracking [candidate] (1.184 ms) : 0, 1184
BytebuddyAgent [baseline] (791.09 ms) : 0, 791090
BytebuddyAgent [candidate] (791.849 ms) : 0, 791849
GlobalTracer [baseline] (255.74 ms) : 0, 255740
GlobalTracer [candidate] (256.243 ms) : 0, 256243
AppSec [baseline] (35.192 ms) : 0, 35192
AppSec [candidate] (35.458 ms) : 0, 35458
Debugger [baseline] (65.715 ms) : 0, 65715
Debugger [candidate] (66.38 ms) : 0, 66380
Remote Config [baseline] (550.832 µs) : 0, 551
Remote Config [candidate] (559.364 µs) : 0, 559
Telemetry [baseline] (8.387 ms) : 0, 8387
Telemetry [candidate] (8.526 ms) : 0, 8526
Flare Poller [baseline] (3.468 ms) : 0, 3468
Flare Poller [candidate] (3.493 ms) : 0, 3493
IAST [baseline] (27.025 ms) : 0, 27025
IAST [candidate] (27.224 ms) : 0, 27224
section profiling
ProfilingAgent [baseline] (99.681 ms) : 0, 99681
ProfilingAgent [candidate] (97.956 ms) : 0, 97956
crashtracking [baseline] (1.186 ms) : 0, 1186
crashtracking [candidate] (1.213 ms) : 0, 1213
BytebuddyAgent [baseline] (701.358 ms) : 0, 701358
BytebuddyAgent [candidate] (704.112 ms) : 0, 704112
GlobalTracer [baseline] (220.598 ms) : 0, 220598
GlobalTracer [candidate] (222.412 ms) : 0, 222412
AppSec [baseline] (32.226 ms) : 0, 32226
AppSec [candidate] (32.511 ms) : 0, 32511
Debugger [baseline] (68.375 ms) : 0, 68375
Debugger [candidate] (67.98 ms) : 0, 67980
Remote Config [baseline] (633.899 µs) : 0, 634
Remote Config [candidate] (644.489 µs) : 0, 644
Telemetry [baseline] (9.029 ms) : 0, 9029
Telemetry [candidate] (9.014 ms) : 0, 9014
Flare Poller [baseline] (3.811 ms) : 0, 3811
Flare Poller [candidate] (3.786 ms) : 0, 3786
Profiling [baseline] (100.281 ms) : 0, 100281
Profiling [candidate] (98.532 ms) : 0, 98532
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~cca1811515, baseline=1.57.0-SNAPSHOT~89639f7e8c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.079 s) : 0, 1078976
Total [baseline] (8.754 s) : 0, 8754212
Agent [candidate] (1.085 s) : 0, 1084589
Total [candidate] (8.795 s) : 0, 8794723
section iast
Agent [baseline] (1.228 s) : 0, 1227554
Total [baseline] (9.497 s) : 0, 9496504
Agent [candidate] (1.224 s) : 0, 1223628
Total [candidate] (9.466 s) : 0, 9465870
gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~cca1811515, baseline=1.57.0-SNAPSHOT~89639f7e8c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.197 ms) : 0, 1197
crashtracking [candidate] (1.196 ms) : 0, 1196
BytebuddyAgent [baseline] (647.611 ms) : 0, 647611
BytebuddyAgent [candidate] (651.262 ms) : 0, 651262
GlobalTracer [baseline] (281.446 ms) : 0, 281446
GlobalTracer [candidate] (282.682 ms) : 0, 282682
AppSec [baseline] (32.275 ms) : 0, 32275
AppSec [candidate] (32.469 ms) : 0, 32469
Debugger [baseline] (67.416 ms) : 0, 67416
Debugger [candidate] (67.906 ms) : 0, 67906
Remote Config [baseline] (703.29 µs) : 0, 703
Remote Config [candidate] (666.318 µs) : 0, 666
Telemetry [baseline] (9.063 ms) : 0, 9063
Telemetry [candidate] (9.019 ms) : 0, 9019
Flare Poller [baseline] (3.743 ms) : 0, 3743
Flare Poller [candidate] (3.723 ms) : 0, 3723
section iast
crashtracking [baseline] (1.198 ms) : 0, 1198
crashtracking [candidate] (1.197 ms) : 0, 1197
BytebuddyAgent [baseline] (794.572 ms) : 0, 794572
BytebuddyAgent [candidate] (791.358 ms) : 0, 791358
GlobalTracer [baseline] (256.042 ms) : 0, 256042
GlobalTracer [candidate] (255.359 ms) : 0, 255359
IAST [baseline] (27.186 ms) : 0, 27186
IAST [candidate] (26.845 ms) : 0, 26845
AppSec [baseline] (35.776 ms) : 0, 35776
AppSec [candidate] (35.503 ms) : 0, 35503
Debugger [baseline] (64.867 ms) : 0, 64867
Debugger [candidate] (65.458 ms) : 0, 65458
Remote Config [baseline] (540.304 µs) : 0, 540
Remote Config [candidate] (537.122 µs) : 0, 537
Telemetry [baseline] (8.4 ms) : 0, 8400
Telemetry [candidate] (8.434 ms) : 0, 8434
Flare Poller [baseline] (3.43 ms) : 0, 3430
Flare Poller [candidate] (3.461 ms) : 0, 3461
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 2 performance regressions! Performance is the same for 17 metrics, 15 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~cca1811515, baseline=1.57.0-SNAPSHOT~89639f7e8c
dateFormat X
axisFormat %s
section baseline
no_agent (19.433 ms) : 19233, 19633
. : milestone, 19433,
appsec (18.663 ms) : 18472, 18855
. : milestone, 18663,
code_origins (17.646 ms) : 17474, 17818
. : milestone, 17646,
iast (17.952 ms) : 17772, 18132
. : milestone, 17952,
profiling (19.664 ms) : 19469, 19860
. : milestone, 19664,
tracing (17.677 ms) : 17502, 17853
. : milestone, 17677,
section candidate
no_agent (18.305 ms) : 18120, 18491
. : milestone, 18305,
appsec (19.491 ms) : 19293, 19689
. : milestone, 19491,
code_origins (18.009 ms) : 17827, 18191
. : milestone, 18009,
iast (17.792 ms) : 17611, 17973
. : milestone, 17792,
profiling (19.013 ms) : 18825, 19200
. : milestone, 19013,
tracing (18.137 ms) : 17957, 18317
. : milestone, 18137,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~cca1811515, baseline=1.57.0-SNAPSHOT~89639f7e8c
dateFormat X
axisFormat %s
section baseline
no_agent (1.23 ms) : 1218, 1243
. : milestone, 1230,
iast (3.164 ms) : 3126, 3202
. : milestone, 3164,
iast_FULL (5.861 ms) : 5802, 5920
. : milestone, 5861,
iast_GLOBAL (3.622 ms) : 3568, 3677
. : milestone, 3622,
profiling (2.245 ms) : 2221, 2269
. : milestone, 2245,
tracing (1.786 ms) : 1771, 1801
. : milestone, 1786,
section candidate
no_agent (1.196 ms) : 1184, 1207
. : milestone, 1196,
iast (3.184 ms) : 3141, 3228
. : milestone, 3184,
iast_FULL (5.973 ms) : 5912, 6033
. : milestone, 5973,
iast_GLOBAL (3.723 ms) : 3667, 3779
. : milestone, 3723,
profiling (2.141 ms) : 2121, 2161
. : milestone, 2141,
tracing (1.814 ms) : 1800, 1829
. : milestone, 1814,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~cca1811515, baseline=1.57.0-SNAPSHOT~89639f7e8c
dateFormat X
axisFormat %s
section baseline
no_agent (14.837 s) : 14837000, 14837000
. : milestone, 14837000,
appsec (14.54 s) : 14540000, 14540000
. : milestone, 14540000,
iast (18.465 s) : 18465000, 18465000
. : milestone, 18465000,
iast_GLOBAL (18.072 s) : 18072000, 18072000
. : milestone, 18072000,
profiling (15.055 s) : 15055000, 15055000
. : milestone, 15055000,
tracing (14.828 s) : 14828000, 14828000
. : milestone, 14828000,
section candidate
no_agent (14.945 s) : 14945000, 14945000
. : milestone, 14945000,
appsec (14.356 s) : 14356000, 14356000
. : milestone, 14356000,
iast (18.449 s) : 18449000, 18449000
. : milestone, 18449000,
iast_GLOBAL (17.837 s) : 17837000, 17837000
. : milestone, 17837000,
profiling (14.555 s) : 14555000, 14555000
. : milestone, 14555000,
tracing (14.813 s) : 14813000, 14813000
. : milestone, 14813000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~cca1811515, baseline=1.57.0-SNAPSHOT~89639f7e8c
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1463, 1486
. : milestone, 1474,
appsec (2.462 ms) : 2410, 2514
. : milestone, 2462,
iast (2.216 ms) : 2152, 2280
. : milestone, 2216,
iast_GLOBAL (2.259 ms) : 2194, 2324
. : milestone, 2259,
profiling (2.095 ms) : 2041, 2149
. : milestone, 2095,
tracing (2.04 ms) : 1989, 2091
. : milestone, 2040,
section candidate
no_agent (1.478 ms) : 1466, 1489
. : milestone, 1478,
appsec (3.654 ms) : 3439, 3870
. : milestone, 3654,
iast (2.204 ms) : 2140, 2268
. : milestone, 2204,
iast_GLOBAL (2.255 ms) : 2190, 2320
. : milestone, 2255,
profiling (2.065 ms) : 2012, 2117
. : milestone, 2065,
tracing (2.042 ms) : 1991, 2093
. : milestone, 2042,
|
communication/src/main/java/datadog/communication/ddagent/DDAgentFeaturesDiscovery.java
Outdated
Show resolved
Hide resolved
# Conflicts: # communication/src/main/java/datadog/communication/ddagent/DDAgentFeaturesDiscovery.java
1ded8e1 to
fb6cf96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
This simplifies the CSS check by combining the agent version check and the
client_drop_p0ssupport as both are required to support CSS.Motivation
Additional Notes
Follow-up to
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]