-
Notifications
You must be signed in to change notification settings - Fork 319
🪞 10020 - Extract trace context from Kafka producer record headers #10022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Kafka / producer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
Kafka / consumer-benchmarkParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 2 metrics, 0 unstable metrics.
See unchanged results
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 11 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~a8cb36a617, baseline=1.57.0-SNAPSHOT~a2f3c7a523
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.105 s) : 0, 1105441
Total [baseline] (8.766 s) : 0, 8766155
Agent [candidate] (1.119 s) : 0, 1119046
Total [candidate] (8.791 s) : 0, 8790584
section iast
Agent [baseline] (1.245 s) : 0, 1245385
Total [baseline] (9.492 s) : 0, 9492301
Agent [candidate] (1.249 s) : 0, 1248866
Total [candidate] (9.497 s) : 0, 9496757
gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~a8cb36a617, baseline=1.57.0-SNAPSHOT~a2f3c7a523
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.496 ms) : 0, 1496
crashtracking [candidate] (1.502 ms) : 0, 1502
BytebuddyAgent [baseline] (691.613 ms) : 0, 691613
BytebuddyAgent [candidate] (700.613 ms) : 0, 700613
GlobalTracer [baseline] (264.714 ms) : 0, 264714
GlobalTracer [candidate] (268.417 ms) : 0, 268417
AppSec [baseline] (32.142 ms) : 0, 32142
AppSec [candidate] (32.496 ms) : 0, 32496
Debugger [baseline] (67.343 ms) : 0, 67343
Debugger [candidate] (67.403 ms) : 0, 67403
Remote Config [baseline] (633.429 µs) : 0, 633
Remote Config [candidate] (641.122 µs) : 0, 641
Telemetry [baseline] (8.858 ms) : 0, 8858
Telemetry [candidate] (8.895 ms) : 0, 8895
Flare Poller [baseline] (3.603 ms) : 0, 3603
Flare Poller [candidate] (3.643 ms) : 0, 3643
section iast
crashtracking [baseline] (1.476 ms) : 0, 1476
crashtracking [candidate] (1.476 ms) : 0, 1476
BytebuddyAgent [baseline] (833.402 ms) : 0, 833402
BytebuddyAgent [candidate] (835.965 ms) : 0, 835965
GlobalTracer [baseline] (237.932 ms) : 0, 237932
GlobalTracer [candidate] (239.09 ms) : 0, 239090
IAST [baseline] (33.441 ms) : 0, 33441
IAST [candidate] (32.758 ms) : 0, 32758
AppSec [baseline] (28.115 ms) : 0, 28115
AppSec [candidate] (28.855 ms) : 0, 28855
Debugger [baseline] (63.522 ms) : 0, 63522
Debugger [candidate] (63.288 ms) : 0, 63288
Remote Config [baseline] (563.707 µs) : 0, 564
Remote Config [candidate] (527.28 µs) : 0, 527
Telemetry [baseline] (8.405 ms) : 0, 8405
Telemetry [candidate] (8.309 ms) : 0, 8309
Flare Poller [baseline] (3.445 ms) : 0, 3445
Flare Poller [candidate] (3.486 ms) : 0, 3486
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~a8cb36a617, baseline=1.57.0-SNAPSHOT~a2f3c7a523
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.111 s) : 0, 1110673
Total [baseline] (10.665 s) : 0, 10664784
Agent [candidate] (1.105 s) : 0, 1104693
Total [candidate] (10.652 s) : 0, 10651963
section appsec
Agent [baseline] (1.29 s) : 0, 1290106
Total [baseline] (11.05 s) : 0, 11049999
Agent [candidate] (1.307 s) : 0, 1307437
Total [candidate] (11.022 s) : 0, 11021619
section iast
Agent [baseline] (1.25 s) : 0, 1249853
Total [baseline] (11.212 s) : 0, 11212357
Agent [candidate] (1.267 s) : 0, 1267201
Total [candidate] (11.369 s) : 0, 11369124
section profiling
Agent [baseline] (1.238 s) : 0, 1237553
Total [baseline] (10.952 s) : 0, 10952289
Agent [candidate] (1.235 s) : 0, 1235311
Total [candidate] (11.026 s) : 0, 11025875
gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~a8cb36a617, baseline=1.57.0-SNAPSHOT~a2f3c7a523
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.49 ms) : 0, 1490
crashtracking [candidate] (1.477 ms) : 0, 1477
BytebuddyAgent [baseline] (695.924 ms) : 0, 695924
BytebuddyAgent [candidate] (691.701 ms) : 0, 691701
GlobalTracer [baseline] (265.065 ms) : 0, 265065
GlobalTracer [candidate] (264.498 ms) : 0, 264498
AppSec [baseline] (32.03 ms) : 0, 32030
AppSec [candidate] (31.744 ms) : 0, 31744
Debugger [baseline] (67.8 ms) : 0, 67800
Debugger [candidate] (67.37 ms) : 0, 67370
Remote Config [baseline] (641.855 µs) : 0, 642
Remote Config [candidate] (669.859 µs) : 0, 670
Telemetry [baseline] (8.848 ms) : 0, 8848
Telemetry [candidate] (8.665 ms) : 0, 8665
Flare Poller [baseline] (3.624 ms) : 0, 3624
Flare Poller [candidate] (3.58 ms) : 0, 3580
section appsec
crashtracking [baseline] (1.47 ms) : 0, 1470
crashtracking [candidate] (1.517 ms) : 0, 1517
BytebuddyAgent [baseline] (733.074 ms) : 0, 733074
BytebuddyAgent [candidate] (743.582 ms) : 0, 743582
GlobalTracer [baseline] (241.11 ms) : 0, 241110
GlobalTracer [candidate] (244.683 ms) : 0, 244683
IAST [baseline] (24.888 ms) : 0, 24888
IAST [candidate] (25.193 ms) : 0, 25193
AppSec [baseline] (175.615 ms) : 0, 175615
AppSec [candidate] (177.2 ms) : 0, 177200
Debugger [baseline] (65.416 ms) : 0, 65416
Debugger [candidate] (66.171 ms) : 0, 66171
Remote Config [baseline] (706.694 µs) : 0, 707
Remote Config [candidate] (719.027 µs) : 0, 719
Telemetry [baseline] (9.025 ms) : 0, 9025
Telemetry [candidate] (9.046 ms) : 0, 9046
Flare Poller [baseline] (3.619 ms) : 0, 3619
Flare Poller [candidate] (3.73 ms) : 0, 3730
section iast
crashtracking [baseline] (1.472 ms) : 0, 1472
crashtracking [candidate] (1.502 ms) : 0, 1502
BytebuddyAgent [baseline] (836.102 ms) : 0, 836102
BytebuddyAgent [candidate] (849.473 ms) : 0, 849473
GlobalTracer [baseline] (238.665 ms) : 0, 238665
GlobalTracer [candidate] (240.866 ms) : 0, 240866
IAST [baseline] (33.908 ms) : 0, 33908
IAST [candidate] (32.454 ms) : 0, 32454
AppSec [baseline] (27.798 ms) : 0, 27798
AppSec [candidate] (29.853 ms) : 0, 29853
Debugger [baseline] (64.297 ms) : 0, 64297
Debugger [candidate] (64.93 ms) : 0, 64930
Remote Config [baseline] (551.288 µs) : 0, 551
Remote Config [candidate] (562.791 µs) : 0, 563
Telemetry [baseline] (8.492 ms) : 0, 8492
Telemetry [candidate] (8.454 ms) : 0, 8454
Flare Poller [baseline] (3.524 ms) : 0, 3524
Flare Poller [candidate] (3.511 ms) : 0, 3511
section profiling
crashtracking [baseline] (1.422 ms) : 0, 1422
crashtracking [candidate] (1.437 ms) : 0, 1437
BytebuddyAgent [baseline] (735.703 ms) : 0, 735703
BytebuddyAgent [candidate] (733.401 ms) : 0, 733401
GlobalTracer [baseline] (222.798 ms) : 0, 222798
GlobalTracer [candidate] (222.258 ms) : 0, 222258
AppSec [baseline] (32.143 ms) : 0, 32143
AppSec [candidate] (32.131 ms) : 0, 32131
Debugger [baseline] (66.638 ms) : 0, 66638
Debugger [candidate] (66.436 ms) : 0, 66436
Remote Config [baseline] (637.386 µs) : 0, 637
Remote Config [candidate] (647.979 µs) : 0, 648
Telemetry [baseline] (8.842 ms) : 0, 8842
Telemetry [candidate] (8.747 ms) : 0, 8747
Flare Poller [baseline] (6.263 ms) : 0, 6263
Flare Poller [candidate] (8.057 ms) : 0, 8057
ProfilingAgent [baseline] (93.703 ms) : 0, 93703
ProfilingAgent [candidate] (92.814 ms) : 0, 92814
Profiling [baseline] (94.28 ms) : 0, 94280
Profiling [candidate] (93.383 ms) : 0, 93383
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 19 metrics, 17 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~a8cb36a617, baseline=1.57.0-SNAPSHOT~a2f3c7a523
dateFormat X
axisFormat %s
section baseline
no_agent (18.545 ms) : 18351, 18738
. : milestone, 18545,
appsec (18.985 ms) : 18789, 19181
. : milestone, 18985,
code_origins (17.483 ms) : 17311, 17656
. : milestone, 17483,
iast (17.627 ms) : 17453, 17802
. : milestone, 17627,
profiling (18.595 ms) : 18409, 18780
. : milestone, 18595,
tracing (17.943 ms) : 17764, 18121
. : milestone, 17943,
section candidate
no_agent (19.613 ms) : 19410, 19817
. : milestone, 19613,
appsec (19.015 ms) : 18822, 19209
. : milestone, 19015,
code_origins (17.772 ms) : 17595, 17948
. : milestone, 17772,
iast (17.691 ms) : 17519, 17864
. : milestone, 17691,
profiling (18.62 ms) : 18438, 18803
. : milestone, 18620,
tracing (17.942 ms) : 17765, 18119
. : milestone, 17942,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~a8cb36a617, baseline=1.57.0-SNAPSHOT~a2f3c7a523
dateFormat X
axisFormat %s
section baseline
no_agent (1.199 ms) : 1187, 1210
. : milestone, 1199,
iast (3.138 ms) : 3105, 3171
. : milestone, 3138,
iast_FULL (5.718 ms) : 5660, 5777
. : milestone, 5718,
iast_GLOBAL (3.515 ms) : 3464, 3565
. : milestone, 3515,
profiling (2.014 ms) : 1996, 2032
. : milestone, 2014,
tracing (1.812 ms) : 1797, 1828
. : milestone, 1812,
section candidate
no_agent (1.202 ms) : 1190, 1214
. : milestone, 1202,
iast (3.175 ms) : 3135, 3215
. : milestone, 3175,
iast_FULL (5.611 ms) : 5556, 5666
. : milestone, 5611,
iast_GLOBAL (3.572 ms) : 3513, 3631
. : milestone, 3572,
profiling (1.934 ms) : 1918, 1951
. : milestone, 1934,
tracing (1.79 ms) : 1776, 1804
. : milestone, 1790,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~a8cb36a617, baseline=1.57.0-SNAPSHOT~a2f3c7a523
dateFormat X
axisFormat %s
section baseline
no_agent (15.232 s) : 15232000, 15232000
. : milestone, 15232000,
appsec (14.784 s) : 14784000, 14784000
. : milestone, 14784000,
iast (17.958 s) : 17958000, 17958000
. : milestone, 17958000,
iast_GLOBAL (18.054 s) : 18054000, 18054000
. : milestone, 18054000,
profiling (14.938 s) : 14938000, 14938000
. : milestone, 14938000,
tracing (14.767 s) : 14767000, 14767000
. : milestone, 14767000,
section candidate
no_agent (15.434 s) : 15434000, 15434000
. : milestone, 15434000,
appsec (14.905 s) : 14905000, 14905000
. : milestone, 14905000,
iast (18.773 s) : 18773000, 18773000
. : milestone, 18773000,
iast_GLOBAL (17.896 s) : 17896000, 17896000
. : milestone, 17896000,
profiling (15.065 s) : 15065000, 15065000
. : milestone, 15065000,
tracing (14.95 s) : 14950000, 14950000
. : milestone, 14950000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~a8cb36a617, baseline=1.57.0-SNAPSHOT~a2f3c7a523
dateFormat X
axisFormat %s
section baseline
no_agent (1.473 ms) : 1462, 1485
. : milestone, 1473,
appsec (3.696 ms) : 3477, 3914
. : milestone, 3696,
iast (2.206 ms) : 2141, 2270
. : milestone, 2206,
iast_GLOBAL (2.249 ms) : 2184, 2313
. : milestone, 2249,
profiling (2.087 ms) : 2033, 2141
. : milestone, 2087,
tracing (2.044 ms) : 1993, 2094
. : milestone, 2044,
section candidate
no_agent (1.47 ms) : 1458, 1481
. : milestone, 1470,
appsec (3.702 ms) : 3484, 3920
. : milestone, 3702,
iast (2.205 ms) : 2140, 2270
. : milestone, 2205,
iast_GLOBAL (2.245 ms) : 2180, 2310
. : milestone, 2245,
profiling (2.054 ms) : 2001, 2106
. : milestone, 2054,
tracing (2.044 ms) : 1993, 2095
. : milestone, 2044,
|
82282ea to
a5a3c26
Compare
a5a3c26 to
5d8b3c9
Compare
Allow Kafka producers to continue existing traces by extracting trace context from record headers and using it as parent for the produce span. This enables distributed tracing when messages are forwarded between services with pre-existing context.
5d8b3c9 to
8fed0a3
Compare
8fed0a3 to
a8cb36a
Compare
This PR mirrors the changes from the original community contribution to enable CI testing with maintainer privileges.
Original PR: #10020
Original Author: @PlugaruT
Original Branch: PlugaruT/dd-trace-java:fix/propagate-kafka-producer-trace-context-if-exists
Closes #10020
This is an automated mirror created to run CI checks. See tooling/mirror-community-pull-request.sh for details.