Skip to content

Revert "Add tags and description to logs pipelines (#3424)" #1992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Revert "Add tags and description to logs pipelines (#3424)" #1992

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c88547
Regenerate client from commit be17a7b8 of spec repo
Jan 13, 2025
3619962
Merge branch 'master' into datadog-api-spec/generated/3473
amaskara-dd Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .apigentools-info
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@
"spec_versions": {
"v1": {
"apigentools_version": "1.6.6",
"regenerated": "2025-01-10 22:21:31.707539",
"spec_repo_commit": "2f8c42a8"
"regenerated": "2025-01-13 17:10:17.417320",
"spec_repo_commit": "be17a7b8"
},
"v2": {
"apigentools_version": "1.6.6",
"regenerated": "2025-01-10 22:21:31.723176",
"spec_repo_commit": "2f8c42a8"
"regenerated": "2025-01-13 17:10:17.436132",
"spec_repo_commit": "be17a7b8"
}
}
}
9 changes: 0 additions & 9 deletions .generator/schemas/v1/openapi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5926,9 +5926,6 @@ components:

Make sure to use an application key created by an admin.'
properties:
description:
description: A description of the pipeline.
type: string
filter:
$ref: '#/components/schemas/LogsFilter'
id:
Expand All @@ -5951,12 +5948,6 @@ components:
items:
$ref: '#/components/schemas/LogsProcessor'
type: array
tags:
description: A list of tags associated with the pipeline.
items:
description: A single tag using the format `key:value`.
type: string
type: array
type:
description: Type of pipeline.
example: pipeline
Expand Down
1 change: 0 additions & 1 deletion examples/v1/logs-pipelines/CreateLogsPipeline.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ rule_name_2 bar
type: "grok-parser",
},
],
tags: [],
},
};

Expand Down
1 change: 0 additions & 1 deletion examples/v1/logs-pipelines/UpdateLogsPipeline.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ rule_name_2 bar
type: "grok-parser",
},
],
tags: [],
},
pipelineId: "pipeline_id",
};
Expand Down
8 changes: 4 additions & 4 deletions features/v1/logs_pipelines.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,14 @@ Feature: Logs Pipelines
@generated @skip @team:DataDog/event-platform-experience
Scenario: Create a pipeline returns "Bad Request" response
Given new "CreateLogsPipeline" request
And body with value {"filter": {"query": "source:python"}, "name": "", "processors": [{"grok": {"match_rules": "rule_name_1 foo\nrule_name_2 bar\n", "support_rules": "rule_name_1 foo\nrule_name_2 bar\n"}, "is_enabled": false, "samples": [], "source": "message", "type": "grok-parser"}], "tags": []}
And body with value {"filter": {"query": "source:python"}, "name": "", "processors": [{"grok": {"match_rules": "rule_name_1 foo\nrule_name_2 bar\n", "support_rules": "rule_name_1 foo\nrule_name_2 bar\n"}, "is_enabled": false, "samples": [], "source": "message", "type": "grok-parser"}]}
When the request is sent
Then the response status is 400 Bad Request

@generated @skip @team:DataDog/event-platform-experience
Scenario: Create a pipeline returns "OK" response
Given new "CreateLogsPipeline" request
And body with value {"filter": {"query": "source:python"}, "name": "", "processors": [{"grok": {"match_rules": "rule_name_1 foo\nrule_name_2 bar\n", "support_rules": "rule_name_1 foo\nrule_name_2 bar\n"}, "is_enabled": false, "samples": [], "source": "message", "type": "grok-parser"}], "tags": []}
And body with value {"filter": {"query": "source:python"}, "name": "", "processors": [{"grok": {"match_rules": "rule_name_1 foo\nrule_name_2 bar\n", "support_rules": "rule_name_1 foo\nrule_name_2 bar\n"}, "is_enabled": false, "samples": [], "source": "message", "type": "grok-parser"}]}
When the request is sent
Then the response status is 200 OK

Expand Down Expand Up @@ -81,15 +81,15 @@ Feature: Logs Pipelines
Scenario: Update a pipeline returns "Bad Request" response
Given new "UpdateLogsPipeline" request
And request contains "pipeline_id" parameter from "REPLACE.ME"
And body with value {"filter": {"query": "source:python"}, "name": "", "processors": [{"grok": {"match_rules": "rule_name_1 foo\nrule_name_2 bar\n", "support_rules": "rule_name_1 foo\nrule_name_2 bar\n"}, "is_enabled": false, "samples": [], "source": "message", "type": "grok-parser"}], "tags": []}
And body with value {"filter": {"query": "source:python"}, "name": "", "processors": [{"grok": {"match_rules": "rule_name_1 foo\nrule_name_2 bar\n", "support_rules": "rule_name_1 foo\nrule_name_2 bar\n"}, "is_enabled": false, "samples": [], "source": "message", "type": "grok-parser"}]}
When the request is sent
Then the response status is 400 Bad Request

@generated @skip @team:DataDog/event-platform-experience
Scenario: Update a pipeline returns "OK" response
Given new "UpdateLogsPipeline" request
And request contains "pipeline_id" parameter from "REPLACE.ME"
And body with value {"filter": {"query": "source:python"}, "name": "", "processors": [{"grok": {"match_rules": "rule_name_1 foo\nrule_name_2 bar\n", "support_rules": "rule_name_1 foo\nrule_name_2 bar\n"}, "is_enabled": false, "samples": [], "source": "message", "type": "grok-parser"}], "tags": []}
And body with value {"filter": {"query": "source:python"}, "name": "", "processors": [{"grok": {"match_rules": "rule_name_1 foo\nrule_name_2 bar\n", "support_rules": "rule_name_1 foo\nrule_name_2 bar\n"}, "is_enabled": false, "samples": [], "source": "message", "type": "grok-parser"}]}
When the request is sent
Then the response status is 200 OK

Expand Down
16 changes: 0 additions & 16 deletions packages/datadog-api-client-v1/models/LogsPipeline.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,6 @@ import { AttributeTypeMap } from "../../datadog-api-client-common/util";
* Make sure to use an application key created by an admin.
*/
export class LogsPipeline {
/**
* A description of the pipeline.
*/
"description"?: string;
/**
* Filter for logs.
*/
Expand All @@ -44,10 +40,6 @@ export class LogsPipeline {
* Ordered list of processors in this pipeline.
*/
"processors"?: Array<LogsProcessor>;
/**
* A list of tags associated with the pipeline.
*/
"tags"?: Array<string>;
/**
* Type of pipeline.
*/
Expand All @@ -69,10 +61,6 @@ export class LogsPipeline {
* @ignore
*/
static readonly attributeTypeMap: AttributeTypeMap = {
description: {
baseName: "description",
type: "string",
},
filter: {
baseName: "filter",
type: "LogsFilter",
Expand All @@ -98,10 +86,6 @@ export class LogsPipeline {
baseName: "processors",
type: "Array<LogsProcessor>",
},
tags: {
baseName: "tags",
type: "Array<string>",
},
type: {
baseName: "type",
type: "string",
Expand Down
Loading