-
Notifications
You must be signed in to change notification settings - Fork 21
fix edge case with periods in keys #2722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix edge case with periods in keys #2722
Conversation
|
/merge |
|
View all feedbacks in Devflow UI.
This merge request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
daniel.trinh@datadoghq.com unqueued this merge request |
|
/remove |
|
View all feedbacks in Devflow UI.
|
|
/merge |
|
View all feedbacks in Devflow UI.
This merge request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
devflow unqueued this merge request: It did not become mergeable within the expected time |
|
Confirmed in Slack that this shouldn't affect the existing generated code. |
What does this PR do?
Fixes the Ruby code formatter to correctly handle hash keys containing special characters (e.g., periods, dashes, spaces) by using hash rocket syntax (
=>) instead of symbol syntax.Problem:
The formatter was generating invalid Ruby syntax for keys with special characters like
"ocsf.activity_name":Solution:
Added validation to check if a key is a valid Ruby symbol. Keys with special characters now use hash rocket syntax:
Valid identifiers (alphanumeric and underscores only) continue to use symbol syntax:
Additional Notes
Review checklist