Skip to content

Use the name if available instead of the default name. #3126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2025
Merged

Use the name if available instead of the default name. #3126

merged 1 commit into from
Sep 11, 2025

Conversation

@jack-edmonds-dd
Copy link
Contributor

@jack-edmonds-dd jack-edmonds-dd commented Sep 10, 2025 •
edited
Loading

This should prevent us from running into the naming collsion that happens when the default_name is already in use for another model.

Tested by running

pre-commit run --all-files --hook-stage=manual generate
pre-commit run --all-files --hook-stage=manual examples
pre-commit run --all-files --hook-stage=manual lint
pre-commit run --all-files --hook-stage=manual lint-examples

And seeing no changes.

What does this PR do?

Additional Notes

Review checklist

Please check relevant items below:

  • This PR includes all newly recorded cassettes for any modified tests.

  • This PR does not rely on API client schema changes.

    • The CI should be fully passing.

  • Or, this PR relies on API schema changes and this is a Draft PR that includes tests.

    • Note: CI shouldn't be run on this Draft PR, as its expected to fail without the corresponding schema changes.

@jack-edmonds-dd
Use the name if available instead of the default name.
6e273e6 
This should prevent us from running into the naming collsion that happens when the default_name is already in use for another model.
@jack-edmonds-dd jack-edmonds-dd requested review from a team as code owners September 10, 2025 20:48
@jack-edmonds-dd jack-edmonds-dd added the changelog/no-changelog Changes don't appear in changelog label Sep 10, 2025
@jack-edmonds-dd jack-edmonds-dd merged commit 2e35725 into master Sep 11, 2025
18 of 19 checks passed
@jack-edmonds-dd jack-edmonds-dd deleted the jack-edmonds-dd/AAWF-618 branch September 11, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MintsInc MintsInc MintsInc approved these changes

Assignees

No one assigned

Labels

changelog/no-changelog Changes don't appear in changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jack-edmonds-dd @MintsInc