fix(home-page): compataibile with old architecture #20
+881
−83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielAraldi
added
documentation
Owner
|
Excellent work, my friend! But I have a question, why did the bob build version go up to 30? Is there any connection between this version and the old architecture? |
DanielAraldi
requested changes
Nov 19, 2025
Owner
DanielAraldi
left a comment
DanielAraldi
left a comment
There was a problem hiding this comment.
Hello @rahulfancode, I found good work, however I didn't understand certain things such as:
- You downgraded the bob builder version, why?
- It's better to separate the logic of the new and old architecture into
oldarchandnewarchfolders, it's a standard, could you do that? - Is using
HostComponentreally necessary instead of codegen?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.