Skip to content

Fixes judgehost down notification #3237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 28, 2025
Merged

Fixes judgehost down notification #3237

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9543805
Fixes judgehost down notification
tuupke Nov 28, 2025
633d14b
Adds type requirements in JudgehostController
tuupke Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion webapp/public/js/domjudge.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -759,7 +759,7 @@ function updateMenuJudgehosts(data)
sendNotification('Judgehost down.',
{'tag': 'host_'+data[i].hostname+'@'+
Math.floor(data[i].polltime),
'link': domjudge_base_url + '/jury/judgehosts/' + encodeURIComponent(data[i].hostname),
'link': domjudge_base_url + '/jury/judgehosts/' + encodeURIComponent(data[i].judgehostid),
'body': data[i].hostname + ' is down'});
}
}
Expand Down
2 changes: 1 addition & 1 deletion webapp/src/Service/DOMJudgeService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,7 @@ public function getUpdates(): array
}

$judgehosts = $this->em->createQueryBuilder()
->select('j.hostname', 'j.polltime')
->select('j.judgehostid', 'j.hostname', 'j.polltime')
->from(Judgehost::class, 'j')
->andWhere('j.enabled = 1')
->andWhere('j.hidden = 0')
Expand Down
Loading