-
Notifications
You must be signed in to change notification settings - Fork 278
Upgrade dependencies for NWERC25 #3215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vmcj
wants to merge
3
commits into
DOMjudge:main
Choose a base branch
from
vmcj:upgrade_dependencies_nwerc25
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1,084
−776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
487d962 to
08d6606
Compare
Member
Author
|
One of the issues is this: |
Member
Fixed that for you, see KnpLabs/KnpPaginatorBundle#842 as to why. |
Member
Author
|
@nickygerritsen thanks, that seems to fix most issues. I think I'll also remove that PHPstan pin and fix that other issue as mentioned in Slack. Afterwards I'll merge. |
…gination templates
We had this before the DTO, PHPstan correctly flags this as a variable which can never be . So we either had to add this null to keep PHPstan wondering or accept that when someone alters the database they get problems.
ccc2be8 to
d6a1722
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.