Skip to content

Conversation

@vmcj
Copy link
Member

@vmcj vmcj commented Nov 23, 2025

No description provided.

@vmcj vmcj force-pushed the upgrade_dependencies_nwerc25 branch 2 times, most recently from 487d962 to 08d6606 Compare November 23, 2025 20:26
@vmcj
Copy link
Member Author

vmcj commented Nov 24, 2025

One of the issues is this:

[2025-11-23T20:30:20.503356+00:00] request.CRITICAL: Uncaught PHP Exception Twig\Error\RuntimeError: "An exception has been thrown during the rendering of a template ("Knp\Bundle\PaginatorBundle\Helper\Processor::__construct(): Argument #2 ($translator) must be of type Symfony\Contracts\Translation\TranslatorInterface, null given, called in /opt/domjudge/domserver/webapp/var/cache/prod/ContainerOjL6COA/getPaginationRuntimeService.php on line 21") in "jury/team.html.twig" at line 9." at team.html.twig line 9 {"exception":"[object] (Twig\\Error\\RuntimeError(code: 0): An exception has been thrown during the rendering of a template (\"Knp\\Bundle\\PaginatorBundle\\Helper\\Processor::__construct(): Argument #2 ($translator) must be of type Symfony\\Contracts\\Translation\\TranslatorInterface, null given, called in /opt/domjudge/domserver/webapp/var/cache/prod/ContainerOjL6COA/getPaginationRuntimeService.php on line 21\") in \"jury/team.html.twig\" at line 9. at /opt/domjudge/domserver/webapp/templates/jury/team.html.twig:9)\n[previous exception] [object] (TypeError(code: 0): Knp\\Bundle\\PaginatorBundle\\Helper\\Processor::__construct(): Argument #2 ($translator) must be of type Symfony\\Contracts\\Translation\\TranslatorInterface, null given, called in /opt/domjudge/domserver/webapp/var/cache/prod/ContainerOjL6COA/getPaginationRuntimeService.php on line 21 at /opt/domjudge/domserver/webapp/vendor/knplabs/knp-paginator-bundle/src/Helper/Processor.php:18)"} []

@nickygerritsen
Copy link
Member

One of the issues is this:

[2025-11-23T20:30:20.503356+00:00] request.CRITICAL: Uncaught PHP Exception Twig\Error\RuntimeError: "An exception has been thrown during the rendering of a template ("Knp\Bundle\PaginatorBundle\Helper\Processor::__construct(): Argument #2 ($translator) must be of type Symfony\Contracts\Translation\TranslatorInterface, null given, called in /opt/domjudge/domserver/webapp/var/cache/prod/ContainerOjL6COA/getPaginationRuntimeService.php on line 21") in "jury/team.html.twig" at line 9." at team.html.twig line 9 {"exception":"[object] (Twig\\Error\\RuntimeError(code: 0): An exception has been thrown during the rendering of a template (\"Knp\\Bundle\\PaginatorBundle\\Helper\\Processor::__construct(): Argument #2 ($translator) must be of type Symfony\\Contracts\\Translation\\TranslatorInterface, null given, called in /opt/domjudge/domserver/webapp/var/cache/prod/ContainerOjL6COA/getPaginationRuntimeService.php on line 21\") in \"jury/team.html.twig\" at line 9. at /opt/domjudge/domserver/webapp/templates/jury/team.html.twig:9)\n[previous exception] [object] (TypeError(code: 0): Knp\\Bundle\\PaginatorBundle\\Helper\\Processor::__construct(): Argument #2 ($translator) must be of type Symfony\\Contracts\\Translation\\TranslatorInterface, null given, called in /opt/domjudge/domserver/webapp/var/cache/prod/ContainerOjL6COA/getPaginationRuntimeService.php on line 21 at /opt/domjudge/domserver/webapp/vendor/knplabs/knp-paginator-bundle/src/Helper/Processor.php:18)"} []

Fixed that for you, see KnpLabs/KnpPaginatorBundle#842 as to why.

@vmcj
Copy link
Member Author

vmcj commented Nov 25, 2025

@nickygerritsen thanks, that seems to fix most issues. I think I'll also remove that PHPstan pin and fix that other issue as mentioned in Slack. Afterwards I'll merge.

vmcj and others added 3 commits November 25, 2025 09:22
We had this before the DTO, PHPstan correctly flags this as a variable which can never be . So we either had to add this null to keep PHPstan wondering or accept that when someone alters the database they get problems.
@vmcj vmcj force-pushed the upgrade_dependencies_nwerc25 branch from ccc2be8 to d6a1722 Compare November 25, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants