Add more frontend packages to yarn #3191
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only after this can we move dataTables itself.
This was forgotten in the earlier commit as only the JS files got symlinked
This was forgotten in the earlier commit as only the JS files got symlinked
We get a warning and as tooltips are hard to find it's probably easier to add it now and detect later if this is an extra dependency we don't need. As we do use dropdown we probably need it.
We couldn't do this before as datatables-bs5 depends on the composer bootstrap install.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've also moved some commits to separate PRs to make reviewing easier per topic. Most important one is 313e026