Skip to content

Conversation

@Kevinjil
Copy link
Contributor

@Kevinjil Kevinjil commented Nov 8, 2025

The monaco package is some indepdantly maintained build and not the original monaco editor. It also seemed incredibly outdated (9y) and not API compatible with the current monaco release and broke the editors. Switch to monaco-editor instead.

The `monaco` package is some indepdantly maintained build and not the
original monaco editor. It also seemed incredibly outdated (9y) and not API
compatible with the current `monaco` release and broke the editors.
Switch to `monaco-editor` instead.
@Kevinjil Kevinjil requested a review from vmcj November 8, 2025 22:01
@Kevinjil
Copy link
Contributor Author

Kevinjil commented Nov 8, 2025

For reference: monaco-editor vs monaco

Copy link
Member

@vmcj vmcj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The monaco package is some indepdantly maintained build and not the original monaco editor. It also seemed incredibly outdated (9y) and not API compatible with the current monaco release and broke the editors. Switch to monaco-editor instead.

I checked again and it seems to work on my side, what breaks for you? But I'm fine with switching to another package.

@Kevinjil
Copy link
Contributor Author

Kevinjil commented Nov 8, 2025

@vmcj E.g. missing the setLanguage function on https://www.domjudge.org/demoweb/jury/submissions/9675/source.

@Kevinjil Kevinjil added this pull request to the merge queue Nov 8, 2025
Merged via the queue into DOMjudge:main with commit dd8c2b7 Nov 8, 2025
37 checks passed
@Kevinjil Kevinjil deleted the fix-yarn-monaco branch November 8, 2025 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants