Skip to content

Conversation

@jmckulk
Copy link
Collaborator

@jmckulk jmckulk commented Sep 19, 2025

Shellcheck was being run on the reload command for pgBackRest. During the auto-grow work, we noticed that the reload command for the instance was not being checked. Since we had to update the auto-grow bash logic to pass Shellcheck for pgBackRest, it seemed appropriate to enable the checks for the instance as well.

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change, as applicable?
  • Have you tested your changes on all related environments with successful results, as applicable?
    • Have you added automated tests?

Type of Changes:

  • New feature
  • Bug fix
  • Documentation
  • Testing enhancement
  • Other

What is the current behavior (link to any open issues here)?

What is the new behavior (if this is a feature change)?

  • Breaking change (fix or feature that would cause existing functionality to change)

Other Information:

@jmckulk jmckulk marked this pull request as ready for review September 19, 2025 19:32
@jmckulk jmckulk requested a review from tjmoore4 September 19, 2025 19:47
Copy link
Contributor

@tjmoore4 tjmoore4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I think we should just add a comment about the script updates.

Shellcheck was being run on the reload command for pgBackRest. During
the auto-grow work, we noticed that the reload command for the instance
was not being checked. Since we had to update the auto-grow bash logic to
pass Shellcheck for pgBackRest, it seemed appropriate to enable the checks for the
instance as well.
@jmckulk jmckulk force-pushed the jmckulk/autogrow-shell-check branch from 4275659 to 195d518 Compare September 19, 2025 20:02
@jmckulk jmckulk merged commit a6ed570 into CrunchyData:main Sep 19, 2025
19 checks passed
@jmckulk jmckulk deleted the jmckulk/autogrow-shell-check branch September 19, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants