Skip to content

Log API warnings at a higher verbosity #4251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 20, 2025
Merged

Log API warnings at a higher verbosity #4251

merged 4 commits into from
Aug 20, 2025

Conversation

@cbandy
Copy link
Member

@cbandy cbandy commented Aug 20, 2025 •
edited
Loading

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change, as applicable?
  • Have you tested your changes on all related environments with successful results, as applicable?
    • Have you added automated tests?

Type of Changes:

  • New feature

What is the current behavior (link to any open issues here)?

Warnings about Endpoints deprecation are logged at the info level.

What is the new behavior (if this is a feature change)?

Warnings about Endpoints deprecation are logged at the debug level when CRUNCHY_DEBUG=2 or higher.

Other Information:

@cbandy cbandy requested a review from andrewlecuyer August 20, 2025 12:26
benjaminjb
benjaminjb reviewed Aug 20, 2025
View reviewed changes
Copy link
Contributor

@benjaminjb benjaminjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like complaining about go mod

cbandy added 4 commits August 20, 2025 10:25
@cbandy
Replace assertNoError with must and need
af0cd7a 
The former is identical and the latter uses generics to return a single
value.
@cbandy
Log API warnings at a higher verbosity
d863824 
Since v0.19.0, controller-runtime has configured its REST clients to log
API warnings at the INFO level.

This changes the CRUNCHY_DEBUG environment variable to accept an integer
that increases the verbosity of logs. API warnings are logged when
verbosity is 2 or higher.
@cbandy
Send leader election messages to the global logger
613034f
@cbandy
Use go mod tidy --diff to validate go.mod
5a9018a 
The "-diff" flag was added in Go 1.23 and does the right thing in a
single command.
@cbandy cbandy merged commit b86f239 into CrunchyData:main Aug 20, 2025
17 checks passed
@cbandy cbandy deleted the rest-logging branch August 20, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjaminjb benjaminjb benjaminjb approved these changes

@andrewlecuyer andrewlecuyer Awaiting requested review from andrewlecuyer

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cbandy @benjaminjb