Add additional volumes to pgbouncer #4240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminjb
force-pushed
the
benjb/additional-volumes-pgbouncer
branch
from
f6c5da5 to
503ac6b
Compare
benjaminjb
changed the title
cbandy
approved these changes
Aug 13, 2025
| return meta.Annotations | ||
| } | ||
|
|
||
| type AdditionalVolume struct { |
Member
There was a problem hiding this comment.
👍🏻 to this move. Watch out for conflict with 6b01868.
* Add additional volume for pgbouncer pods Change the API to allow users to specify preexisting PVCs to attach to specified containers in the pgbouncer instance pods. The spec allows users to specify whether to add the volume to - all containers (by omitting the containers list) - no containers (by specifying an empty containers list) - a list of named containers If any of the named containers isn't present, we continue to reconcile, but issue a warning event with the names of the missing containers. Issues: [PGO-2557]
benjaminjb
force-pushed
the
benjb/additional-volumes-pgbouncer
branch
from
145345a to
9c5ce98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Type of Changes:
What is the current behavior (link to any open issues here)?
Hard to attach PVCs to pgbouncer pods
What is the new behavior (if this is a feature change)?
Add additional volumes to pgbouncer pods
Other Information:
PGO-2557