Move Postgres log rotation parameters to the postgres package #4215
Conversation
| - pkg: math/rand$ | ||
| desc: Use the "math/rand/v2" package instead. See https://go.dev/doc/go1.22#math_rand_v2 |
There was a problem hiding this comment.
Any reason behind the switch to v2?
There was a problem hiding this comment.
No reason to stay away from v1, really. The v2 rand.N is generic, so it can do time.Duration without casts; that was nice.
The behavior of these parameters is independent of OpenTelemetry. This refactor is part of a larger series to make the Postgres log directory configurable.
| prefix := strings.ReplaceAll(filePrefix, "%", "%%") | ||
| suffix := strings.ReplaceAll(fileSuffix, "%", "%%") |
There was a problem hiding this comment.
⛏️ we're doubling % to escape in case the prefix/suffix have % -- but ours don't, right?
and if someone forgot/missed that we're handling this and doubled the % originally, we'd quadruple the %?
There was a problem hiding this comment.
ours don't, right?
Right. Escaping occurred to me as I was writing the test. I expect the postgres package to know about these details, while other packages don't.
if someone forgot/missed that we're handling this and doubled the
%originally, we'd quadruple the%?
Yep. If someone thinks to escape before calling, their test would show the wacky number of escapes.
3 participants
Checklist:
Type of Changes:
This moves the
log_filenameandlog_rotationparameters intointernal/postgres, documents how they're related, and adds some tests. 📝 Theinternal/collectortests don't change.Issue: PGO-2558