Enable more Go linters and document exclusions #4200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
cbandy
force-pushed
the
more-linters
branch
2 times, most recently
from
9c77f66 to
c7e2d19
Compare
cbandy
commented
Jul 10, 2025
| awk >> "${GITHUB_STEP_SUMMARY}" ' | ||
| NR == 1 { print "```json" } { print } END { if (NR > 0) print "```" } | ||
| ' || true | ||
| golangci-lint run --config .golangci.next.yaml --show-stats >> "${GITHUB_STEP_SUMMARY}" \ |
Member
Author
There was a problem hiding this comment.
📝 --show-stats prints a sorted list now.
https://github.com/CrunchyData/postgres-operator/actions/runs/16202244008
benjaminjb
approved these changes
Jul 10, 2025
Member
Author
|
A variety of KUTTL tests were failing, so I reverted my changes in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used
golangci-lint migrateto get to v2, and that dropped the configuration comments we had in v1. This puts those back, enables new linters available in v2, and updates the "next" configuration similarly.Checklist:
Type of Changes: