Skip to content

Conversation

@benjaminjb
Copy link
Contributor

@benjaminjb benjaminjb commented Mar 24, 2025

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change, as applicable?
  • Have you tested your changes on all related environments with successful results, as applicable?
    • Have you added automated tests?

Type of Changes:

  • New feature
  • Bug fix
  • Documentation
  • Testing enhancement
  • Other

What is the current behavior (link to any open issues here)?

bug when only enabling metrics: containers that expect logrotate hang

What is the new behavior (if this is a feature change)?

  • Breaking change (fix or feature that would cause existing functionality to change)

Change logic to includeLogrotate

Only logrotate if
- boolean is true and
- OTel log gate is on

Other Information:

logrotate conf should be optional
Only logrotate if
- boolean is true and
- OTel log gate is on
@benjaminjb benjaminjb merged commit d7e5657 into main Mar 24, 2025
19 checks passed
@benjaminjb benjaminjb deleted the benjb/logrotate-conf-optional branch March 24, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants