Otel custom queries #4126
Merged
Otel custom queries #4126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsessler7
commented
Mar 6, 2025
pkg/apis/postgres-operator.crunchydata.com/v1beta1/instrumentation_types.go
Show resolved
Hide resolved
benjaminjb
reviewed
Mar 10, 2025
benjaminjb
reviewed
Mar 10, 2025
benjaminjb
reviewed
Mar 10, 2025
pkg/apis/postgres-operator.crunchydata.com/v1beta1/instrumentation_types.go
Show resolved
Hide resolved
benjaminjb
reviewed
Mar 10, 2025
benjaminjb
reviewed
Mar 10, 2025
dsessler7
force-pushed
the
otel-custom-queries
branch
from
ee1434b to
7bc0c03
Compare
benjaminjb
reviewed
Mar 11, 2025
benjaminjb
approved these changes
Mar 11, 2025
Contributor
benjaminjb
left a comment
benjaminjb
left a comment
There was a problem hiding this comment.
Oh, and just double checking -- all the pods/custom query behavior still works, yeah?
Contributor
Author
|
Ha, yup! Everything still works. |
* Add section for metrics collection configuration to instrumentation API * Add provided custom queries file(s) to the config volume and create a new sqlquery receiver * Remove specified metrics from the default metrics; if all metrics for a given query are removed, remove the query as well * Add a collector label for discovery purposes
dsessler7
force-pushed
the
otel-custom-queries
branch
from
b4430fc to
f57e04d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Type of Changes:
What is the current behavior (link to any open issues here)?
No way to customize queries for metrics when using OTel feature.
What is the new behavior (if this is a feature change)?
You can now both provide custom queries/metrics and turn off existing ones when using the OpenTelemetryMetrics feature.
Other Information: