Add an API struct representing a single Secret value #4100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminjb
approved these changes
Feb 20, 2025
cbandy
commented
Feb 20, 2025
config/crd/bases/postgres-operator.crunchydata.com_pgadmins.yaml
Outdated
Show resolved
Hide resolved
This adds validation to the recurring pattern of selecting a single value from a Secret. Note that the "name" field is now required. Secrets are best mounted as files, and the logic for translating these references into volume projections is now consolidated in two exported methods.
cbandy
force-pushed
the
shared-api-structs
branch
from
5b40675 to
dd23d3e
Compare
cbandy
commented
Feb 20, 2025
| type: string | ||
| x-kubernetes-validations: | ||
| - message: cannot be "." or start with ".." | ||
| rule: self != "." && !self.startsWith("..") |
Member
Author
There was a problem hiding this comment.
📝 Having a CEL rule felt like a bit much, but if we allow these values up-front, then we'll error trying to send them into volume source, secret ref, etc during reconcile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds validation to the recurring pattern of selecting a single value from a Secret. Note that the
namefield is now required.Secrets are best mounted as files, and the logic for translating these references into volume projections is now consolidated in two exported methods.
Checklist:
Type of Changes:
What is the current behavior (link to any open issues here)?
Secret name is not validated as required, and forgetting to add it causes reconciliation errors.
What is the new behavior (if this is a feature change)?
The field is now required, but clusters that lack it are broken anyway.