Skip to content

Patch memory corruption bug in fontforge #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pontus123456 merged 1 commit into from
May 30, 2025
Merged

Patch memory corruption bug in fontforge #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## 0.2.2

* Patch memory corruption bug due to PNG background images being the incorrect size.
* Patch memory corruption bug in `fontforge` triggered by some fonts.

## 0.2.1

Expand Down
1 change: 1 addition & 0 deletions src/Pdf2Html/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ RUN patch ./poppler/glib/poppler-enums.c.template ./patches/poppler-enums.c.temp
RUN patch ./poppler/glib/poppler-private.h ./patches/poppler-private.h.patch
RUN ./buildScripts/buildPoppler
RUN ./buildScripts/getFontforge
RUN patch ./fontforge/fontforge/tottfgpos.c ./patches/fontforge-tottfgpos.c.patch
RUN ./buildScripts/buildFontforge
RUN ./buildScripts/buildPdf2htmlEX
RUN ./buildScripts/installPdf2htmlEX
Expand Down
13 changes: 13 additions & 0 deletions src/Pdf2Html/pdf2htmlEX/patches/fontforge-tottfgpos.c.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
@@ -2091,10 +2091,10 @@
}

static uint16 *FigureInitialClasses(FPST *fpst) {
- uint16 *initial = malloc((fpst->nccnt+1)*sizeof(uint16));
+ uint16 *initial = malloc((fpst->rule_cnt+1)*sizeof(uint16));
int i, cnt, j;

- initial[fpst->nccnt] = 0xffff;
+ initial[fpst->rule_cnt] = 0xffff;
for ( i=cnt=0; i<fpst->rule_cnt; ++i ) {
for ( j=0; j<cnt ; ++j )
if ( initial[j] == fpst->rules[i].u.class.nclasses[0] )