-
Notifications
You must be signed in to change notification settings - Fork 123
[ColorHelper] Add new ColorHelper API #754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…r discourage new usage
…were being treated as errors in the CI
…a breaking change betwen ColorHelper.FromHsv and HsvColor.Create
|
Okay. So C# 14 features will work with .NET 9, but the CI environment is stuck on C# 13. |
zubinqayam
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avid29:Color-Helper2
zubinqayam
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avid29:Color-Helper
zubinqayam
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avid29:Color-Helper4
zubinqayam
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avid29:Color-Helper6
Fixes CommunityToolkit/Labs-Windows#756
PR Type
What kind of change does this PR introduce?
This PR introduces a new API for the
ColorHelper, though leaves the old API available with no breaking changes (though marked as deprecated)What is the current behavior?
This is the current API
What is the new behavior?
This is the full new API, including the old API marked obsolete.
PR Checklist
Please check if your PR fulfills the following requirements:
By keeping the old fields available and using the new properties to wrap them, breaking changes have been averted. However, the plan would be to removed these deprecated APIs in future versions.
Other information
Note that the
ObsoleteAttributemessages contain a recommendation for how to migrate to the new API. All these migrations have complete behavioral parity, except the fields/properties inHslColorandHsvColorwhich are now clamped to a valid range.