fix(quickopen): prevent crash by providing UndoManagerRegistration #2124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…View to prevent crash
thecoolwinter
approved these changes
Sep 2, 2025
Collaborator
thecoolwinter
left a comment
thecoolwinter
left a comment
There was a problem hiding this comment.
LGTM, good catch. This would have been caught with a simple automation test, I'll add some to the QuickOpen panel later.
thecoolwinter
requested review from
0xWDG,
austincondiff and
matthijseikelenboom
0xWDG
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix crash in Open Quickly preview caused by missing UndoManagerRegistration.
Root cause: OpenQuicklyPreviewView renders CodeFileView in a separate view hierarchy without the environment object.
Fix: Provide UndoManagerRegistration for the preview (non-editable) path so CodeFileView resolves it.
Reproduce: Open Quickly (CMD+SHIFT+O) -> select a text file -> previously crashed.
Validation: No crash; normal editing unaffected.