Skip to content

Conversation

@thecoolwinter
Copy link
Collaborator

Description

Adjusts the setup of EditorManager to always assign the workspace property on all editors after restoring it. This creates duplicate work when we have editors that successfully restore from a saved state, but ensures we always set up the editor manager correctly even when an error is thrown or there is no restoration data.

Adjusted UI tests to catch this.

Related Issues

  • Issue on discord.

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

N/A

@thecoolwinter thecoolwinter added the bug Something isn't working label Aug 26, 2025
@thecoolwinter thecoolwinter merged commit 05704cb into CodeEditApp:main Aug 26, 2025
2 checks passed
@thecoolwinter thecoolwinter deleted the fix/new-workspace-editors branch August 26, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant