Skip to content

Conversation

@thecoolwinter
Copy link
Collaborator

@thecoolwinter thecoolwinter commented Aug 25, 2025

Description

There has been work done to ensure CodeEdit cleans up language servers correctly on quit, this fixes a few final bugs with that system.

  • Changes the withTimeout call's try to try? in the AppDelegate so a thrown timeout error still allows execution to continue.
  • Removes an unnecessary withTimeout in the language server shutdown code.
  • Ensures withTimeout always cancels all child tasks on either an error or a return value.

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

@thecoolwinter thecoolwinter merged commit 86a08eb into CodeEditApp:main Aug 25, 2025
2 checks passed
@thecoolwinter thecoolwinter added the bug Something isn't working label Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant