Fix Split View Can't Collapse #2071
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Nice catch! How do editor splits work with this? We do not want editors to collapse on drag. |
Collaborator
Author
Those are handled differently and retain the correct behavior with this change. |
austincondiff
requested review from
0xWDG,
FastestMolasses,
austincondiff,
georgetchelidze,
matthijseikelenboom and
tom-ludwig
austincondiff
approved these changes
Jun 24, 2025
tom-ludwig
approved these changes
Jun 26, 2025
0xWDG
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an erroneous overridden method causing split views to not be collapsable.
Related Issues
Checklist
Screenshots
Screen.Recording.2025-06-23.at.11.21.38.AM.mov