Skip to content

Add indication for externally deleted files #1999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Mar 13, 2025
Merged

Add indication for externally deleted files #1999

merged 9 commits into from
Mar 13, 2025

Conversation

@pro100filipp
Copy link
Contributor

@pro100filipp pro100filipp commented Feb 25, 2025

Description

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

1936.mov

austincondiff
austincondiff previously approved these changes Feb 25, 2025
View reviewed changes
Copy link
Collaborator

@austincondiff austincondiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice, solid work! 🔥

matthijseikelenboom
matthijseikelenboom previously approved these changes Feb 27, 2025
View reviewed changes
tom-ludwig
tom-ludwig requested changes Feb 27, 2025
View reviewed changes
Copy link
Member

@tom-ludwig tom-ludwig left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing job Filipp! Just two suggestions 😁

@pro100filipp
Copy link
Contributor Author

pro100filipp commented Feb 28, 2025

Implemented all suggested changes

austincondiff
austincondiff requested changes Mar 4, 2025
View reviewed changes
Copy link
Collaborator

@austincondiff austincondiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix failed tests

@pro100filipp
Copy link
Contributor Author

pro100filipp commented Mar 11, 2025

Sorry for being absent, will fix the pipeline in a few days (though the error seems strange to me)

@austincondiff
Copy link
Collaborator

austincondiff commented Mar 11, 2025

Just a heads up, we’ve pushed a change, converting all Xcode groups to folders, and made some adjustments to updated SwiftLint a few others. This might impact these issues and I would recommend updating with main before attempting to fix anything.

@pro100filipp
Copy link
Contributor Author

pro100filipp commented Mar 12, 2025

Fixed errors from the pipeline, could you please approve it again

@austincondiff
Copy link
Collaborator

austincondiff commented Mar 12, 2025

It looks like there is a small SwiftLint error. Pleas fix it before we move forward.

@pro100filipp
Copy link
Contributor Author

pro100filipp commented Mar 12, 2025

It looks like there is a small SwiftLint error. Pleas fix it before we move forward.

My bad, sorry. Fixed it

@austincondiff
Copy link
Collaborator

austincondiff commented Mar 12, 2025

✅ Approved like it was 1999 🕺

@pro100filipp pro100filipp requested a review from tom-ludwig March 13, 2025 06:12
tom-ludwig
tom-ludwig reviewed Mar 13, 2025
View reviewed changes
Copy link
Member

@tom-ludwig tom-ludwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thank you very much for your contribution

@tom-ludwig tom-ludwig merged commit 9cabecd into CodeEditApp:main Mar 13, 2025
3 of 4 checks passed
@thecoolwinter
Copy link
Collaborator

thecoolwinter commented Apr 8, 2025

@allcontributors please add @pro100filipp for code

@allcontributors allcontributors bot mentioned this pull request Apr 8, 2025
Merged
@allcontributors
Copy link
Contributor

allcontributors bot commented Apr 8, 2025

@thecoolwinter

I've put up a pull request to add @pro100filipp! 🎉

@austincondiff austincondiff mentioned this pull request Apr 17, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@austincondiff austincondiff austincondiff approved these changes

@tom-ludwig tom-ludwig tom-ludwig approved these changes

@matthijseikelenboom matthijseikelenboom matthijseikelenboom left review comments

@thecoolwinter thecoolwinter Awaiting requested review from thecoolwinter

Assignees

@pro100filipp pro100filipp

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pro100filipp @austincondiff @thecoolwinter @matthijseikelenboom @tom-ludwig