Integrated Terminal - Added support Fish Shell #1908
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
October 16, 2024 21:56
Add the fish shell to the enums and reading the config.fish only at present.
Thought installing fish through homebrew would install under /bin/ path but that's not the case. Add few UI changes to select and test out the shell though not working at the moment.
Added the shell script to locate the fish config and use it. Had forgot about it intially, on how we can locate the original fish shell config.
ghost
marked this pull request as ready for review
| case .zsh: | ||
| "/bin/zsh" | ||
| case .fish: | ||
| "/opt/homebrew/bin/fish" |
Collaborator
There was a problem hiding this comment.
@nis-ship-it Is this safe to assume that the fish binary will always be installed by homebrew?
Author
There was a problem hiding this comment.
Yes it might be different so I will try to figure on how to obtain path
Collaborator
There was a problem hiding this comment.
We might look at how other editors handle this
austincondiff
requested changes
Oct 23, 2024
At this stage, we're basically running a process that calls zsh shell to run which fish and get the path.
Member
|
It would be nice if it defaulted to zsh/bash when Fish isn’t available. A small red message in the terminal like |
Author
|
@tom-ludwig I was thinking also the same switching to zsh since it's by default |
ghost
closed this by deleting the head repository
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the fish shell to the enums and reading the config.fish only at present.
Related Issues
Checklist
Screenshots